From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 20 Sep 2013 09:58:20 +0200 From: Thierry Reding Subject: Re: [PATCH v4] PWM: PXA: add device tree support to PWM driver Message-ID: <20130920075819.GC8575@ulmo> References: <1379519982-7618-1-git-send-email-mikedunn@newsguy.com> <20130919122807.GH10852@ulmo> <523B2C0B.4050204@newsguy.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Content-Disposition: inline In-Reply-To: <523B2C0B.4050204@newsguy.com> List-ID: To: Mike Dunn Cc: linux-pwm@vger.kernel.org, Grant Likely , Rob Herring , Haojian Zhuang , Robert Jarzmik , Marek Vasut , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dmitry Torokhov , Chao Xie , Sergei Shtylyov , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell --s9fJI615cBHmzTOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 19, 2013 at 09:53:31AM -0700, Mike Dunn wrote: > On 09/19/2013 05:28 AM, Thierry Reding wrote: > > On Wed, Sep 18, 2013 at 08:59:42AM -0700, Mike Dunn wrote: > > [...] > >> Only an OF match table is added; > > [...] > >=20 > > That's no longer true. You also add a custom .of_xlate() function. >=20 >=20 > Is it acceptable to re-word the commit message in susbequent versions? Yes, of course. The commit message should be an accurate description of the patch. If as a result of review the patch changes in ways that make the commit message wrong, then it must be updated as well. > >> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.= dtsi > >=20 > > I think this belongs in a separate patch so it can go through the > > arm-soc tree. >=20 >=20 > Is there anyone else or another list that should be CC'd in this case? T= hanks. Well, the PXA maintainers would be the most likely to take the dtsi change through their tree. Usually the mach trees are merged into arm-soc, which then goes into Linus' tree. > >> +{ > >> + struct pwm_device *pwm; > >> + > >=20 > > You probably want to check that pc->of_pwm_n_cells at least 1 here. >=20 >=20 > Well OK, but I didn't bother because it's explicitly set to one elsewhere= in > this source file. Okay, nevermind. It's probably fine as is. Thierry --s9fJI615cBHmzTOP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iQIcBAEBAgAGBQJSPAAbAAoJEN0jrNd/PrOhAqIQAJ4D+83aWBs7hzIHEvrBBV5b QdBw0wWlT53bEbieV7+9TbHdd8V0m3eX2xGKR5YLIj7Un+Huq00NzQG95TNeeuv5 an0hCPrxScVtZsYL1R+ZTb1qj5VwqF2SXEzqNWo3iJXvNTbzyclp1MRhJy85oq8Z GzHgeTqjAMTsFaehq/V3KnoNHadgSyJteMiMzF/jipjfMmGVIjnW0RPKgLE0Cq0n HkLEn/t2rhDY+8e/Ko9lc0TJ4eC8FIooujtLwyHJDGdCR0wzSSkBjP9VQbB2+r9+ vXUQMYyBr3k37ZMeX/BVtyF1dcGJNw+DnxKvJEFRPeqsAuTxHT2fRM829uI5Hqco HG4yYHoSgaz1WCo1nBW2B2UlE04djObgEQZvappwHQtlsU7YYvhLm9dwEZPc8WAY 57Oqk8xGu2VeLsK6etKaFb+btogSU+fYsfOcXIv3x4acZpXKypOrPECLcC/PxgXk LMeCyXUWX9flmGhM9ifblvNxMKrp05EvUb5m+XRKCGE7iKkNpoHt7dwbvI1vBfSM 4CeQUvWlPbknylFcYgCW1QjxxfM2b6fL0mKn8X2wxbxqVLuQZqcksoj06Z3yGZjq P7Zu42/ptp/I/sEzxWPRzGVWsEwfDRHKlPEnZGmVaRlm4CyXoDywCiW4kTjkM0nk 3wneaCtaHEVZOJJWCPGz =MRM1 -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Fri, 20 Sep 2013 09:58:20 +0200 Subject: [PATCH v4] PWM: PXA: add device tree support to PWM driver In-Reply-To: <523B2C0B.4050204@newsguy.com> References: <1379519982-7618-1-git-send-email-mikedunn@newsguy.com> <20130919122807.GH10852@ulmo> <523B2C0B.4050204@newsguy.com> Message-ID: <20130920075819.GC8575@ulmo> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 19, 2013 at 09:53:31AM -0700, Mike Dunn wrote: > On 09/19/2013 05:28 AM, Thierry Reding wrote: > > On Wed, Sep 18, 2013 at 08:59:42AM -0700, Mike Dunn wrote: > > [...] > >> Only an OF match table is added; > > [...] > > > > That's no longer true. You also add a custom .of_xlate() function. > > > Is it acceptable to re-word the commit message in susbequent versions? Yes, of course. The commit message should be an accurate description of the patch. If as a result of review the patch changes in ways that make the commit message wrong, then it must be updated as well. > >> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > > > > I think this belongs in a separate patch so it can go through the > > arm-soc tree. > > > Is there anyone else or another list that should be CC'd in this case? Thanks. Well, the PXA maintainers would be the most likely to take the dtsi change through their tree. Usually the mach trees are merged into arm-soc, which then goes into Linus' tree. > >> +{ > >> + struct pwm_device *pwm; > >> + > > > > You probably want to check that pc->of_pwm_n_cells at least 1 here. > > > Well OK, but I didn't bother because it's explicitly set to one elsewhere in > this source file. Okay, nevermind. It's probably fine as is. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v4] PWM: PXA: add device tree support to PWM driver Date: Fri, 20 Sep 2013 09:58:20 +0200 Message-ID: <20130920075819.GC8575@ulmo> References: <1379519982-7618-1-git-send-email-mikedunn@newsguy.com> <20130919122807.GH10852@ulmo> <523B2C0B.4050204@newsguy.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s9fJI615cBHmzTOP" Return-path: Content-Disposition: inline In-Reply-To: <523B2C0B.4050204-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mike Dunn Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Grant Likely , Rob Herring , Haojian Zhuang , Robert Jarzmik , Marek Vasut , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Dmitry Torokhov , Chao Xie , Sergei Shtylyov , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell List-Id: devicetree@vger.kernel.org --s9fJI615cBHmzTOP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 19, 2013 at 09:53:31AM -0700, Mike Dunn wrote: > On 09/19/2013 05:28 AM, Thierry Reding wrote: > > On Wed, Sep 18, 2013 at 08:59:42AM -0700, Mike Dunn wrote: > > [...] > >> Only an OF match table is added; > > [...] > >=20 > > That's no longer true. You also add a custom .of_xlate() function. >=20 >=20 > Is it acceptable to re-word the commit message in susbequent versions? Yes, of course. The commit message should be an accurate description of the patch. If as a result of review the patch changes in ways that make the commit message wrong, then it must be updated as well. > >> diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.= dtsi > >=20 > > I think this belongs in a separate patch so it can go through the > > arm-soc tree. >=20 >=20 > Is there anyone else or another list that should be CC'd in this case? T= hanks. Well, the PXA maintainers would be the most likely to take the dtsi change through their tree. Usually the mach trees are merged into arm-soc, which then goes into Linus' tree. > >> +{ > >> + struct pwm_device *pwm; > >> + > >=20 > > You probably want to check that pc->of_pwm_n_cells at least 1 here. >=20 >=20 > Well OK, but I didn't bother because it's explicitly set to one elsewhere= in > this source file. Okay, nevermind. It's probably fine as is. Thierry --s9fJI615cBHmzTOP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (GNU/Linux) iQIcBAEBAgAGBQJSPAAbAAoJEN0jrNd/PrOhAqIQAJ4D+83aWBs7hzIHEvrBBV5b QdBw0wWlT53bEbieV7+9TbHdd8V0m3eX2xGKR5YLIj7Un+Huq00NzQG95TNeeuv5 an0hCPrxScVtZsYL1R+ZTb1qj5VwqF2SXEzqNWo3iJXvNTbzyclp1MRhJy85oq8Z GzHgeTqjAMTsFaehq/V3KnoNHadgSyJteMiMzF/jipjfMmGVIjnW0RPKgLE0Cq0n HkLEn/t2rhDY+8e/Ko9lc0TJ4eC8FIooujtLwyHJDGdCR0wzSSkBjP9VQbB2+r9+ vXUQMYyBr3k37ZMeX/BVtyF1dcGJNw+DnxKvJEFRPeqsAuTxHT2fRM829uI5Hqco HG4yYHoSgaz1WCo1nBW2B2UlE04djObgEQZvappwHQtlsU7YYvhLm9dwEZPc8WAY 57Oqk8xGu2VeLsK6etKaFb+btogSU+fYsfOcXIv3x4acZpXKypOrPECLcC/PxgXk LMeCyXUWX9flmGhM9ifblvNxMKrp05EvUb5m+XRKCGE7iKkNpoHt7dwbvI1vBfSM 4CeQUvWlPbknylFcYgCW1QjxxfM2b6fL0mKn8X2wxbxqVLuQZqcksoj06Z3yGZjq P7Zu42/ptp/I/sEzxWPRzGVWsEwfDRHKlPEnZGmVaRlm4CyXoDywCiW4kTjkM0nk 3wneaCtaHEVZOJJWCPGz =MRM1 -----END PGP SIGNATURE----- --s9fJI615cBHmzTOP-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html