From: Mel Gorman <mgorman@suse.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Kent Overstreet <kmo@daterainc.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Hannes Reinecke <hare@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored
Date: Fri, 20 Sep 2013 09:28:07 +0100 [thread overview]
Message-ID: <20130920082807.GW22421@suse.de> (raw)
In-Reply-To: <20130920080637.GV22421@suse.de>
On Fri, Sep 20, 2013 at 09:06:37AM +0100, Mel Gorman wrote:
> On Thu, Sep 19, 2013 at 08:06:02PM -0700, Darrick J. Wong wrote:
> > The "force" parameter in __blk_queue_bounce was being ignored, which means that
> > stable page snapshots are not always happening (on ext3). This of course
> > leads to DIF disks reporting checksum errors, so fix this regression.
> >
> > The regression was introduced in commit 6bc454d1 (bounce: Refactor
> > __blk_queue_bounce to not use bi_io_vec)
> >
> > Reported-by: Mel Gorman <mgorman@suse.de>
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> I have no means of testing it but it looks right and thanks for checking
> DIF disks.
>
> Acked-by: Mel Gorman <mgorman@suse.de>
>
That said the two checks are now redundant. They could just be deleted
and depend entirely on the following check within the loop
if (page_to_pfn(page) <= queue_bounce_pfn(q) && !force)
continue;
with an update to the comment explaining that the check is for pages
below the bounce pfn or for bios that require stable writes
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2013-09-20 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 3:06 [PATCH] mm: Fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored Darrick J. Wong
2013-09-20 3:28 ` Mike Snitzer
2013-09-20 8:06 ` Mel Gorman
2013-09-20 8:28 ` Mel Gorman [this message]
2013-09-20 16:54 ` Darrick J. Wong
2013-09-24 8:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920082807.GW22421@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.