All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] block: qemu-iotests for vhdx, read sample dynamic imagee
Date: Fri, 20 Sep 2013 07:24:33 -0400	[thread overview]
Message-ID: <20130920112433.GK15106@localhost.localdomain> (raw)
In-Reply-To: <20130920091814.GC2800@dhcp-200-207.str.redhat.com>

On Fri, Sep 20, 2013 at 11:18:14AM +0200, Kevin Wolf wrote:
> Am 20.09.2013 um 11:10 hat Alex Bennée geschrieben:
> > 
> > jcody@redhat.com writes:
> > 
> > > This adds the VHDX format to the qemu-iotests format, and adds
> > > a read test.  The test reads from an existing sample image, that
> > > was created with Hyper-V under Windwos Server 2012.
> > >
> > > The image file is a 1GB dynamic image, with 32MB blocks.
> > >
> > > The pattern 0xa5 exists from 0MB-33MB (past a block size boundary)
> > >
> > > The pattern 0x96 exists from 33MB-66MB (past another block boundary,
> > > and leaving a partial blank block)
> > >
> > > From 66MB-1024MB, all reads should return 0.
> > >
> > > Although 1GB dynamic image with 66MB of data, the bzip2'ed image
> > > file size is only 874 bytes.
> > 
> > I take it there is additional meta-data in there generated by Windows
> > Server itself? Otherwise I would be tempted to write a tool to generate
> > the image on demand so it could be used to trigger other edge cases when
> > found.
> > 
> > Having said that 874 bytes certainly isn't to heavy a burden for the
> > repository ;-)
> 
> Eventually, qemu-img will be able to create VHDX images, but I think the
> point is that we compare against real Hyper-V VHDX images to ensure that
> we're really reading the spec the same way as they do.
> 

Exactly.  If we use qemu-img to generate test images, we aren't really
testing QEMU's compatibility with non-native formats.

Also, it may be useful to occasionally put native images (qcow2, qed)
in the sample_images directory for some major release, so that we can
run some image format regression tests on image format code changes.


> > I'm currently pondering what the best way of supporting system images
> > (i.e. kernel+rootfs) would be to make system regression testing easier.
> > Unfortunately those images would be far too large to carry in the repo
> > although there may be some sub-module annex type thing I could try.
> 
> Sounds like you're looking for qemu-tests?
> 
>     http://git.qemu.org/?p=qemu-test.git;a=summary
>

There is also autotest:
https://github.com/autotest/virt-test/wiki

      parent reply	other threads:[~2013-09-20 11:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20  3:48 [Qemu-devel] [PATCH 0/2] qemu-iotests with sample images, vhdx read test Jeff Cody
2013-09-20  3:48 ` [Qemu-devel] [PATCH 1/2] block: qemu-iotests - add basic ability to use binary sample images Jeff Cody
2013-09-20 12:32   ` Stefan Hajnoczi
2013-09-20 12:41     ` Jeff Cody
2013-09-20 12:46   ` Eric Blake
2013-09-20 13:23     ` Jeff Cody
2013-09-20  3:48 ` [Qemu-devel] [PATCH 2/2] block: qemu-iotests for vhdx, read sample dynamic image Jeff Cody
2013-09-20  9:10   ` [Qemu-devel] [PATCH 2/2] block: qemu-iotests for vhdx, read sample dynamic imagee Alex Bennée
2013-09-20  9:18     ` Kevin Wolf
2013-09-20 10:54       ` Alex Bennée
2013-09-20 11:24       ` Jeff Cody [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130920112433.GK15106@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.