From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2H9-0002XD-Qw for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:05:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VN2H4-00078B-R0 for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:05:43 -0400 Received: from nodalink.pck.nerim.net ([62.212.105.220]:37457 helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VN2H4-000786-BT for qemu-devel@nongnu.org; Fri, 20 Sep 2013 11:05:38 -0400 Date: Fri, 20 Sep 2013 17:05:34 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20130920150533.GG6794@irqsave.net> References: <1379678070-14346-1-git-send-email-kwolf@redhat.com> <1379678070-14346-11-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1379678070-14346-11-git-send-email-kwolf@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/17] blockdev: Move parsing of 'boot' option to drive_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com Le Friday 20 Sep 2013 =E0 13:54:23 (+0200), Kevin Wolf a =E9crit : > It's already ignored and only prints a deprecation message. No use in > making it available in new interfaces. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) >=20 > diff --git a/blockdev.c b/blockdev.c > index ba8b6b4..33383be 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -453,12 +453,6 @@ static DriveInfo *blockdev_init(QDict *bs_opts, > return NULL; > } > =20 > - if (qemu_opt_get(opts, "boot") !=3D NULL) { > - fprintf(stderr, "qemu-kvm: boot=3Don|off is deprecated and wil= l be " > - "ignored. Future versions will reject this parameter. = Please " > - "update your scripts.\n"); > - } > - > on_write_error =3D BLOCKDEV_ON_ERROR_ENOSPC; > if ((buf =3D qemu_opt_get(opts, "werror")) !=3D NULL) { > if (type !=3D IF_IDE && type !=3D IF_SCSI && type !=3D IF_VIRT= IO && type !=3D IF_NONE) { > @@ -710,6 +704,10 @@ QemuOptsList qemu_legacy_drive_opts =3D { > .name =3D "trans", > .type =3D QEMU_OPT_STRING, > .help =3D "chs translation (auto, lba. none)", > + },{ > + .name =3D "boot", > + .type =3D QEMU_OPT_BOOL, > + .help =3D "(deprecated, ignored)", > }, > { /* end of list */ } > }, > @@ -785,6 +783,13 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInt= erfaceType block_default_type) > goto fail; > } > =20 > + /* Deprecated option boot=3D[on|off] */ > + if (qemu_opt_get(legacy_opts, "boot") !=3D NULL) { > + fprintf(stderr, "qemu-kvm: boot=3Don|off is deprecated and wil= l be " > + "ignored. Future versions will reject this parameter. = Please " > + "update your scripts.\n"); > + } > + > /* Media type */ > value =3D qemu_opt_get(legacy_opts, "media"); > if (value) { > @@ -2325,10 +2330,6 @@ QemuOptsList qemu_common_drive_opts =3D { > .name =3D "copy-on-read", > .type =3D QEMU_OPT_BOOL, > .help =3D "copy read data from backing file into image fil= e", > - },{ > - .name =3D "boot", > - .type =3D QEMU_OPT_BOOL, > - .help =3D "(deprecated, ignored)", > }, > { /* end of list */ } > }, > --=20 > 1.8.1.4 >=20 >=20 Reviewed-for-c-bugs-by: Benoit Canet