From: Holger Eitzenberger <holger@eitzenberger.org>
To: <netfilter-devel@vger.kernel.org>
Cc: <kaber@trash.net>
Subject: [FIX 0/1] sip: add missing RCU reader lock in set_expected_rtp_rtcp()
Date: Fri, 20 Sep 2013 17:52:17 +0200 [thread overview]
Message-ID: <20130920155217.281613399@eitzenberger.org> (raw)
I noticed that set_expected_rtp_rtcp() in net-next misses a 2nd
RCU reader lock when dereferencing the 2nd hook function. Same
bug is present in kernel v3.8 at least.
It is not simply a matter of extending the RCU read protected
area because there is a conditional return in between:
if (skip_expect)
return NF_ACCEPT;
Please check the RCU usage. I see e. g. that nf_ct_expect_related(),
takes nf_conntrack_lock, but my understanding of RCU is that
this is ok.
Thanks.
/Holger
next reply other threads:[~2013-09-20 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:52 Holger Eitzenberger [this message]
2013-09-20 15:52 ` [FIX 1/1] sip: add missing RCU reader lock Holger Eitzenberger
2013-09-20 16:55 ` Patrick McHardy
2013-09-20 20:20 ` Holger Eitzenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920155217.281613399@eitzenberger.org \
--to=holger@eitzenberger.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.