From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Russell King <linux@arm.linux.org.uk>,
Joe Perches <joe@perches.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng
Date: Fri, 20 Sep 2013 11:31:44 -0700 [thread overview]
Message-ID: <20130920183144.GB2684@atomide.com> (raw)
In-Reply-To: <201309202024.50755@pali>
* Pali Rohár <pali.rohar@gmail.com> [130920 11:32]:
> On Friday 20 September 2013 19:46:41 Tony Lindgren wrote:
>
> Ok, then there is new patch which only adding omap3-rom-rng and not removing omap_rng.
> It is OK to have same CLK data but with different names?
Yes in this case it's always either omap_rng or omap3-rom-rng
so the patch below looks OK to me.
Regards,
Tony
> diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c
> index 334b767..03a2829 100644
> --- a/arch/arm/mach-omap2/cclock3xxx_data.c
> +++ b/arch/arm/mach-omap2/cclock3xxx_data.c
> @@ -3275,6 +3275,7 @@ static struct omap_clk omap36xx_clks[] = {
> static struct omap_clk omap34xx_omap36xx_clks[] = {
> CLK(NULL, "aes1_ick", &aes1_ick),
> CLK("omap_rng", "ick", &rng_ick),
> + CLK("omap3-rom-rng", "ick", &rng_ick),
> CLK(NULL, "sha11_ick", &sha11_ick),
> CLK(NULL, "des1_ick", &des1_ick),
> CLK(NULL, "cam_mclk", &cam_mclk),
>
>
> --
> Pali Rohár
> pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Russell King <linux@arm.linux.org.uk>,
Joe Perches <joe@perches.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng
Date: Fri, 20 Sep 2013 11:31:44 -0700 [thread overview]
Message-ID: <20130920183144.GB2684@atomide.com> (raw)
In-Reply-To: <201309202024.50755@pali>
* Pali Rohár <pali.rohar@gmail.com> [130920 11:32]:
> On Friday 20 September 2013 19:46:41 Tony Lindgren wrote:
>
> Ok, then there is new patch which only adding omap3-rom-rng and not removing omap_rng.
> It is OK to have same CLK data but with different names?
Yes in this case it's always either omap_rng or omap3-rom-rng
so the patch below looks OK to me.
Regards,
Tony
> diff --git a/arch/arm/mach-omap2/cclock3xxx_data.c b/arch/arm/mach-omap2/cclock3xxx_data.c
> index 334b767..03a2829 100644
> --- a/arch/arm/mach-omap2/cclock3xxx_data.c
> +++ b/arch/arm/mach-omap2/cclock3xxx_data.c
> @@ -3275,6 +3275,7 @@ static struct omap_clk omap36xx_clks[] = {
> static struct omap_clk omap34xx_omap36xx_clks[] = {
> CLK(NULL, "aes1_ick", &aes1_ick),
> CLK("omap_rng", "ick", &rng_ick),
> + CLK("omap3-rom-rng", "ick", &rng_ick),
> CLK(NULL, "sha11_ick", &sha11_ick),
> CLK(NULL, "des1_ick", &des1_ick),
> CLK(NULL, "cam_mclk", &cam_mclk),
>
>
> --
> Pali Rohár
> pali.rohar@gmail.com
next prev parent reply other threads:[~2013-09-20 18:31 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 18:05 [PATCH] OMAP3 ROM Random Number Generator support Pali Rohár
2013-02-28 18:05 ` Pali Rohár
2013-03-24 14:15 ` Pali Rohár
2013-03-24 14:15 ` Pali Rohár
2013-03-27 21:09 ` Tony Lindgren
2013-03-27 21:09 ` Tony Lindgren
2013-03-27 22:03 ` Pali Rohár
2013-03-27 22:03 ` Pali Rohár
2013-03-27 22:25 ` Tony Lindgren
2013-03-27 22:25 ` Tony Lindgren
2013-03-28 17:54 ` Pali Rohár
2013-03-28 17:54 ` Pali Rohár
2013-03-28 21:44 ` Tony Lindgren
2013-03-28 21:44 ` Tony Lindgren
2013-03-31 9:28 ` Pali Rohár
2013-03-31 9:28 ` Pali Rohár
2013-04-01 16:25 ` Tony Lindgren
2013-04-01 16:25 ` Tony Lindgren
2013-09-18 20:05 ` [PATCH 0/2] " Pali Rohár
2013-09-18 20:05 ` Pali Rohár
2013-09-18 20:05 ` [PATCH 1/2] hwrng: " Pali Rohár
2013-09-18 20:05 ` Pali Rohár
2013-09-18 20:22 ` Joe Perches
2013-09-18 20:22 ` Joe Perches
2013-09-18 20:50 ` Aaro Koskinen
2013-09-18 20:50 ` Aaro Koskinen
2013-09-18 20:05 ` [PATCH 2/2] RX-51: Add support for OMAP3 ROM Random Number Generator Pali Rohár
2013-09-18 20:05 ` Pali Rohár
2013-09-18 20:39 ` Tony Lindgren
2013-09-18 20:39 ` Tony Lindgren
2013-09-20 13:25 ` [PATCH v2 0/3] OMAP3 ROM Random Number Generator support Pali Rohár
2013-09-20 13:25 ` Pali Rohár
2013-09-20 13:25 ` [PATCH v2 1/3] omap2: Change clk dev id for rng to omap3-rom-rng Pali Rohár
2013-09-20 13:25 ` Pali Rohár
2013-09-20 16:23 ` Tony Lindgren
2013-09-20 16:23 ` Tony Lindgren
2013-09-20 16:41 ` Pali Rohár
2013-09-20 16:41 ` Pali Rohár
2013-09-20 17:46 ` Tony Lindgren
2013-09-20 17:46 ` Tony Lindgren
2013-09-20 18:24 ` Pali Rohár
2013-09-20 18:24 ` Pali Rohár
2013-09-20 18:31 ` Tony Lindgren [this message]
2013-09-20 18:31 ` Tony Lindgren
2013-09-20 13:25 ` [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support Pali Rohár
2013-09-20 13:25 ` Pali Rohár
2013-10-08 19:04 ` Tony Lindgren
2013-10-08 19:04 ` Tony Lindgren
2013-10-16 12:57 ` Herbert Xu
2013-10-16 12:57 ` Herbert Xu
2013-11-18 21:51 ` Pali Rohár
2013-11-18 21:51 ` Pali Rohár
2013-11-19 2:14 ` Herbert Xu
2013-11-19 2:14 ` Herbert Xu
2013-11-23 9:37 ` Pali Rohár
2013-11-23 9:37 ` Pali Rohár
2013-11-23 12:09 ` Sebastian Reichel
2013-09-20 13:25 ` [PATCH v2 3/3] RX-51: Add support for OMAP3 ROM Random Number Generator Pali Rohár
2013-09-20 13:25 ` Pali Rohár
2013-10-08 19:06 ` Tony Lindgren
2013-10-08 19:06 ` Tony Lindgren
2013-03-28 9:52 ` [PATCH] OMAP3 ROM Random Number Generator support Russell King - ARM Linux
2013-03-28 9:52 ` Russell King - ARM Linux
2013-03-28 17:24 ` Pali Rohár
2013-03-28 17:24 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920183144.GB2684@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=herbert@gondor.apana.org.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mpm@selenic.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.