From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?utf-8?q?St=C3=BCbner?= Date: Fri, 20 Sep 2013 19:26:27 +0200 Subject: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call In-Reply-To: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Message-ID: <201309201926.29084.heiko@sntech.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russell King Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Solarflare linux maintainers , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vinod Koul , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?utf-8?q?St=C3=BCbner?= Subject: Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call Date: Fri, 20 Sep 2013 19:26:27 +0200 Message-ID: <201309201926.29084.heiko@sntech.de> References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "b43-dev" Errors-To: b43-dev-bounces+gldbd-bcm43xx-dev=gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Russell King Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Solarflare linux maintainers , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vinod Koul , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: alsa-devel@alsa-project.org Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?utf-8?q?St=C3=BCbner?= Date: Fri, 20 Sep 2013 17:26:27 +0000 Subject: Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call Message-Id: <201309201926.29084.heiko@sntech.de> List-Id: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russell King Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, e1000-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Solarflare linux maintainers , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vinod Koul , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?utf-8?q?St=C3=BCbner?=) Date: Fri, 20 Sep 2013 19:26:27 +0200 Subject: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call In-Reply-To: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Message-ID: <201309201926.29084.heiko@sntech.de> Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from gloria.sntech.de ([95.129.55.99]:53579 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204Ab3ITR1N (ORCPT ); Fri, 20 Sep 2013 13:27:13 -0400 From: Heiko =?utf-8?q?St=C3=BCbner?= To: Russell King Subject: Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call Date: Fri, 20 Sep 2013 19:26:27 +0200 Cc: alsa-devel@alsa-project.org, b43-dev@lists.infradead.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, e1000-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-ide@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-nvme@lists.infradead.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Solarflare linux maintainers , uclinux-dist-devel@blackfin.uclinux.org, Dan Williams , Vinod Koul References: <20130919212235.GD12758@n2100.arm.linux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201309201926.29084.heiko@sntech.de> (sfid-20130920_192725_941930_5BE43643) Sender: linux-wireless-owner@vger.kernel.org List-ID: Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gloria.sntech.de (gloria.sntech.de [95.129.55.99]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6B3C72C017C for ; Sat, 21 Sep 2013 03:55:33 +1000 (EST) From: Heiko =?utf-8?q?St=C3=BCbner?= To: Russell King Subject: Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call Date: Fri, 20 Sep 2013 19:26:27 +0200 References: <20130919212235.GD12758@n2100.arm.linux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201309201926.29084.heiko@sntech.de> Cc: alsa-devel@alsa-project.org, linux-doc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-nvme@lists.infradead.org, linux-ide@vger.kernel.org, devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net, b43-dev@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, Dan Williams , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Solarflare linux maintainers , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, Vinod Koul , linux-crypto@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?utf-8?q?St=C3=BCbner?=) Date: Fri, 20 Sep 2013 19:26:27 +0200 Subject: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call In-Reply-To: References: <20130919212235.GD12758@n2100.arm.linux.org.uk> Message-ID: <201309201926.29084.heiko@sntech.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. ^--- copy and paste error - should of course be PL330 > Signed-off-by: Russell King > --- > drivers/dma/pl330.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > index a562d24..df8b10f 100644 > --- a/drivers/dma/pl330.c > +++ b/drivers/dma/pl330.c > @@ -2903,6 +2903,10 @@ pl330_probe(struct amba_device *adev, const struct > amba_id *id) > > pdat = dev_get_platdata(&adev->dev); > > + ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32)); > + if (ret) > + return ret; > + > /* Allocate a new DMAC and its Channels */ > pdmac = devm_kzalloc(&adev->dev, sizeof(*pdmac), GFP_KERNEL); > if (!pdmac) {