From: Matthew Whitehead <tedheadster@gmail.com>
To: Mihir Singh <me@mihirsingh.com>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name
Date: Sun, 22 Sep 2013 22:26:22 -0400 [thread overview]
Message-ID: <20130923022621.GB17124@gmail.com> (raw)
In-Reply-To: <1379789289-10961-1-git-send-email-me@mihirsingh.com>
On Sat, Sep 21, 2013 at 06:48:09PM +0000, Mihir Singh wrote:
> The /proc/interrupts file displays hp100, which is not the accepted style. Printing eth%d is more helpful.
>
> Signed-off-by: Mihir Singh <me@mihirsingh.com>
> ---
> drivers/net/ethernet/hp/hp100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/hp/hp100.c b/drivers/net/ethernet/hp/hp100.c
> index 91227d0..3786009 100644
> --- a/drivers/net/ethernet/hp/hp100.c
> +++ b/drivers/net/ethernet/hp/hp100.c
> @@ -1098,7 +1098,7 @@ static int hp100_open(struct net_device *dev)
> if (request_irq(dev->irq, hp100_interrupt,
> lp->bus == HP100_BUS_PCI || lp->bus ==
> HP100_BUS_EISA ? IRQF_SHARED : 0,
> - "hp100", dev)) {
> + dev->name, dev)) {
> printk("hp100: %s: unable to get IRQ %d\n", dev->name, dev->irq);
> return -EAGAIN;
> }
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-By: Matthew Whitehead <tedheadster@gmail.com>
next prev parent reply other threads:[~2013-09-23 2:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 18:48 [net-next] hp100: replace hardcoded name in /proc/interrupts with interface name Mihir Singh
2013-09-23 2:26 ` Matthew Whitehead [this message]
2013-09-27 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923022621.GB17124@gmail.com \
--to=tedheadster@gmail.com \
--cc=me@mihirsingh.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.