Re: [PATCH v3] mfd: add STw481x driver

[Lee Jones <lee.jones@linaro.org>]

> This adds a driver for the STw481x PMICs found in the Nomadik
> family of platforms. This one uses pure device tree probing.
> Print some of the OTP registers on boot and register a regulator
> MFD child.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v2->v3:
> - Instead of using "dummy" as the unused device ID, use "stw481x".
> ChangeLog v1->v2:
> - Fix remnant checkpatch errors.
> - #define some more registers to make things clear.
> - Document the power control register access function.
> - Don't free devm_*-allocated devices.
> - Use module_i2c_driver() macro.
> ---
>  drivers/mfd/Kconfig         |  10 ++
>  drivers/mfd/Makefile        |   1 +
>  drivers/mfd/stw481x.c       | 250 ++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/stw481x.h |  56 ++++++++++
>  4 files changed, 317 insertions(+)
>  create mode 100644 drivers/mfd/stw481x.c
>  create mode 100644 include/linux/mfd/stw481x.h

Nit:

> +static const struct i2c_device_id stw481x_id[] = {
> +	{ "stw481x", 0 },
> +	{ }

Where we have '{ }'.

> +};
> +
> +static const struct of_device_id stw481x_match[] = {
> +	{ .compatible = "st,stw4810", },
> +	{ .compatible = "st,stw4811", },
> +	{},

And just down here the same function is provided with '{},'.

I'm happy to change it myself, rather that asking you to resubmit.

Which to you prefer?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog