From: Vinod Koul <vinod.koul@intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: djbw@fb.com, grant.likely@linaro.org, rob.herring@calxeda.com,
yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH -next] dma: mmp_pdma: use list_move instead of list_del/list_add
Date: Mon, 23 Sep 2013 15:32:53 +0530 [thread overview]
Message-ID: <20130923100253.GG17188@intel.com> (raw)
In-Reply-To: <CAPgLHd9SeN1OdCKqTP2w_rFi3TWD=b+7vL4iwx53KwnMF23Nxg@mail.gmail.com>
On Mon, Sep 23, 2013 at 02:07:20PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move() instead of list_del() + list_add().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks
~Vinod
> ---
> drivers/dma/mmp_pdma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
> index ff8d7827..558994f 100644
> --- a/drivers/dma/mmp_pdma.c
> +++ b/drivers/dma/mmp_pdma.c
> @@ -798,8 +798,7 @@ static void dma_do_tasklet(unsigned long data)
> * move the descriptors to a temporary list so we can drop
> * the lock during the entire cleanup operation
> */
> - list_del(&desc->node);
> - list_add(&desc->node, &chain_cleanup);
> + list_move(&desc->node, &chain_cleanup);
>
> /*
> * Look for the first list entry which has the ENDIRQEN flag
>
--
prev parent reply other threads:[~2013-09-23 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 6:07 [PATCH -next] dma: mmp_pdma: use list_move instead of list_del/list_add Wei Yongjun
2013-09-23 6:07 ` Wei Yongjun
2013-09-23 10:02 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923100253.GG17188@intel.com \
--to=vinod.koul@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=djbw@fb.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.