Re: [meta-networking][PATCH 3/3] barnyard: add recipe

[Joe MacDonald <joe@deserted.net>]

[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]

[[oe] [meta-networking][PATCH 3/3] barnyard:  add recipe] On 13.09.23 (Mon 17:20) b40290@freescale.com wrote:

> From: Chunrong Guo <B40290@freescale.com>
> 
>   *Barnyard is a output system for Snort
> 
> Signed-off-by: Chunrong Guo <B40290@freescale.com>
> ---
>  .../barnyard/barnyard_0.2.0.bb                     |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 meta-networking/recipes-connectivity/barnyard/barnyard_0.2.0.bb
> 
> diff --git a/meta-networking/recipes-connectivity/barnyard/barnyard_0.2.0.bb b/meta-networking/recipes-connectivity/barnyard/barnyard_0.2.0.bb
> new file mode 100644
> index 0000000..c5e0e78
> --- /dev/null
> +++ b/meta-networking/recipes-connectivity/barnyard/barnyard_0.2.0.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "Barnyard is a output system for Snort."
> +HOMEPAGE = "http://www.snort.org/"
> +LICENSE = "QPL"

I think this is QPL-1.0.

> +LIC_FILES_CHKSUM = "file://LICENSE.QPL;md5=1b8ff8c0012b5a2d647357699bf44b41"
> +
> +DEPENDS = "libpcap"
> +
> +SRC_URI = " ${GENTOO_MIRROR}/${BP}.tar.gz;name=tarball \
> +          "

In line with my other request about SRC_URI formatting, can you update
this as well?  I think you can remove the ";name=tarball" piece and you
can move the bottom " back up against the left margin.

I'm curious, too, about the SRC_URI itself.  Why GENTOO_MIRROR instead
of the SourceForge site?

Also, do you really need Barnyard and not Barnyard2?  Barnyard2 is the
one currently referenced on snort.org and it appears to be a full
re-write.  Since the original Barnyard appears to be somewhat idle, I'd
be more inclined to adopt Barnyard2 and leave the older version behind.
Perhaps there's a good reason to use the older one, though.  I can
surely be convinced.  :-)

> +SRC_URI[tarball.md5sum] = "be3283028cf414b52b220308ceb411e9"
> +SRC_URI[tarball.sha256sum] = "09e0f8e095e79cfe70ea069d13e7d02521a504a1f400a45556a634dccfd31a3a"
> +
> +inherit autotools pkgconfig
> +
> +do_configure_prepend () {
> +	#fix hardcoded include path
> +	sed -i -e 's:extra_incl=-I/usr/include/pcap::g' ${S}/configure.in
> +}
> +

This is probably a fine solution for the snort host include path issue,
too.

Thanks.

-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]