From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by arago-project.org (Postfix) with ESMTPS id CD7795296F for ; Tue, 24 Sep 2013 00:41:44 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id r8O0fiCR025779 for ; Mon, 23 Sep 2013 19:41:44 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8O0fief025016 for ; Mon, 23 Sep 2013 19:41:44 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Mon, 23 Sep 2013 19:41:44 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8O0fhDY014020; Mon, 23 Sep 2013 19:41:43 -0500 Date: Mon, 23 Sep 2013 20:41:43 -0400 From: Denys Dmytriyenko To: "Franklin S. Cooper Jr" Message-ID: <20130924004143.GA4390@edge> References: <1379985594-25515-1-git-send-email-fcooper@ti.com> MIME-Version: 1.0 In-Reply-To: <1379985594-25515-1-git-send-email-fcooper@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-arago@arago-project.org Subject: Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2013 00:41:45 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Heh, just sent out my updated patch and noticed you had one as well... And they are so similar! I'm just wondering why you spent time on it, when I said I'll fix it? -- Denys On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote: > * Latest kernel sources included symbolic links that were broken and caused the > tar command to fail. > * In certain circumstances broken symbolic links are valid and should be > packaged up. > * However, any patch located in the "patches" directory should be dereference > * since the original file is located in the recipe's WORKDIR. > * Therefore, the sym link will be broken when accessed on a different computer. > * By using the dereference option with the cp command the patches directory can > be dereferenced. > > Signed-off-by: Franklin S. Cooper Jr > --- > meta-arago-distro/classes/sourceipk.bbclass | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass > index 1ea0577..3086670 100644 > --- a/meta-arago-distro/classes/sourceipk.bbclass > +++ b/meta-arago-distro/classes/sourceipk.bbclass > @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() { > cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/ > fi > > + # Dereference symbolic links to patches that are stored in patches directory > + if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ] > + then > + > + mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak > + cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak $tmp_dir/${SRCIPK_INSTALL_DIR}/patches > + rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak > + fi > + > + > #Write the data tarball > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > # Create the debian-binary file > echo "2.0" > $srcipk_dir/debian-binary > -- > 1.7.0.4 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago