From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by arago-project.org (Postfix) with ESMTPS id 4EA82529A0 for ; Tue, 24 Sep 2013 00:56:46 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r8O0ujQZ029302 for ; Mon, 23 Sep 2013 19:56:45 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8O0uj7H010356 for ; Mon, 23 Sep 2013 19:56:45 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Mon, 23 Sep 2013 19:56:45 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r8O0ujGk018029; Mon, 23 Sep 2013 19:56:45 -0500 Date: Mon, 23 Sep 2013 20:56:44 -0400 From: Denys Dmytriyenko To: "Cooper Jr., Franklin" Message-ID: <20130924005644.GC4390@edge> References: <1379985594-25515-1-git-send-email-fcooper@ti.com> <20130924004143.GA4390@edge> <8F29D6B095ED194EA1980491A5E029710C55B6D5@DFLE08.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C55B6D5@DFLE08.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH] sourceipk.bbclass: Dereference sym links located in patches directory X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2013 00:56:46 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Mon, Sep 23, 2013 at 08:49:10PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, September 23, 2013 7:42 PM > > To: Cooper Jr., Franklin > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] sourceipk.bbclass: Dereference sym links > > located in patches directory > > > > Heh, just sent out my updated patch and noticed you had one as well... And > > they are so similar! I'm just wondering why you spent time on it, when I said I'll > > fix it? > [Franklin] Lol yeah. Must of overlooked the part where you said you were > going to fix it and I needed it for my SDK build I want to start tomorrow > morning. Ah, I didn't know you needed it sooner - I was working on it and testing it in-between my main work today on meta-qt5 and switching other platforms to 3.12 kernel. That's why it took me a while to get it out... > > On Mon, Sep 23, 2013 at 08:19:54PM -0500, Franklin S. Cooper Jr wrote: > > > * Latest kernel sources included symbolic links that were broken and caused > > the > > > tar command to fail. > > > * In certain circumstances broken symbolic links are valid and should be > > > packaged up. > > > * However, any patch located in the "patches" directory should be > > dereference > > > * since the original file is located in the recipe's WORKDIR. > > > * Therefore, the sym link will be broken when accessed on a different > > computer. > > > * By using the dereference option with the cp command the patches directory > > can > > > be dereferenced. > > > > > > Signed-off-by: Franklin S. Cooper Jr > > > --- > > > meta-arago-distro/classes/sourceipk.bbclass | 12 +++++++++++- > > > 1 files changed, 11 insertions(+), 1 deletions(-) > > > > > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > > distro/classes/sourceipk.bbclass > > > index 1ea0577..3086670 100644 > > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > > @@ -166,8 +166,18 @@ sourceipk_do_create_srcipk() { > > > cp ${FILE} $tmp_dir/${SRCIPK_INSTALL_DIR}/ > > > fi > > > > > > + # Dereference symbolic links to patches that are stored in patches > > directory > > > + if [ -d "$tmp_dir/${SRCIPK_INSTALL_DIR}/patches" ] > > > + then > > > + > > > + mv $tmp_dir/${SRCIPK_INSTALL_DIR}/patches > > $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak > > > + cp -rL $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak > > $tmp_dir/${SRCIPK_INSTALL_DIR}/patches > > > + rm -rf $tmp_dir/${SRCIPK_INSTALL_DIR}/patches_bak > > > + fi > > > + > > > + > > > #Write the data tarball > > > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > > > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > > > > > # Create the debian-binary file > > > echo "2.0" > $srcipk_dir/debian-binary > > > -- > > > 1.7.0.4 > > > > > > _______________________________________________ > > > meta-arago mailing list > > > meta-arago@arago-project.org > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago