From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2.39 7/7] datapath: Add basic MPLS support to kernel Date: Tue, 24 Sep 2013 10:33:22 +0900 Message-ID: <20130924013322.GM25601@verge.net.au> References: <1378711207-29890-1-git-send-email-horms@verge.net.au> <1378711207-29890-8-git-send-email-horms@verge.net.au> <20130918220756.GA24919@verge.net.au> <20130922053800.GA4890@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pravin Shelar , "dev@openvswitch.org" , netdev , Ravi K , Isaku Yamahata , Joe Stringer To: Jesse Gross Return-path: Received: from kirsty.vergenet.net ([202.4.237.240]:49077 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551Ab3IXBdZ (ORCPT ); Mon, 23 Sep 2013 21:33:25 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Sep 23, 2013 at 02:24:31PM -0700, Jesse Gross wrote: > On Mon, Sep 23, 2013 at 12:47 PM, Pravin Shelar wrote: > > This patch does not work since vport-netdev does not include compat > > gso header. after including gso.h it gives me compiler error. > > Can you post combined patch with fixes? > > I think it's probably because of this: > > +#if 1 // LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) > +#define dev_queue_xmit rpl_dev_queue_xmit > +#endif > > But otherwise, I agree the approach is much nicer than what is currently there. Sorry for letting that slip through. I'll post a more complete patch after doing some more testing.