From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace Date: Tue, 24 Sep 2013 12:48:57 +0200 Message-ID: <20130924104855.GB4532@8bytes.org> References: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Shuah Khan Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org, fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, udknight-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote: > +DEFINE_EVENT(iommu_fault, report_fault, > + > + TP_PROTO(struct device *dev, unsigned long iova, int flags), > + > + TP_ARGS(dev, iova, flags) > +); I am not entirely happy with the naming. It is better to name the class iommu_error and the page-fault event io_page_fault. This makes it more clear what kind of fault it is. Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961Ab3IXKtE (ORCPT ); Tue, 24 Sep 2013 06:49:04 -0400 Received: from 8bytes.org ([85.214.48.195]:45221 "EHLO mail.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab3IXKtC (ORCPT ); Tue, 24 Sep 2013 06:49:02 -0400 Date: Tue, 24 Sep 2013 12:48:57 +0200 From: Joerg Roedel To: Shuah Khan Cc: alex.williamson@redhat.com, Varun.Sethi@freescale.com, udknight@gmail.com, aik@ozlabs.ru, rostedt@goodmis.org, fweisbec@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, shuahkhan@gmail.com Subject: Re: [PATCH 1/2] iommu: Add iommu_fault class event to iommu trace Message-ID: <20130924104855.GB4532@8bytes.org> References: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a14c27d8341e53f2aed7b80e08a4480d89eac5e.1376672275.git.shuah.kh@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-DSPAM-Result: Whitelisted X-DSPAM-Processed: Tue Sep 24 12:49:01 2013 X-DSPAM-Confidence: 0.9988 X-DSPAM-Probability: 0.0000 X-DSPAM-Signature: 52416e1d20861661348221 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2013 at 11:20:16AM -0600, Shuah Khan wrote: > +DEFINE_EVENT(iommu_fault, report_fault, > + > + TP_PROTO(struct device *dev, unsigned long iova, int flags), > + > + TP_ARGS(dev, iova, flags) > +); I am not entirely happy with the naming. It is better to name the class iommu_error and the page-fault event io_page_fault. This makes it more clear what kind of fault it is. Joerg