From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 24 Sep 2013 14:32:25 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:43547 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6825728Ab3IXMcTyU3Mo (ORCPT ); Tue, 24 Sep 2013 14:32:19 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id r8OCWGEC027203; Tue, 24 Sep 2013 14:32:16 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id r8OCWCrk027195; Tue, 24 Sep 2013 14:32:12 +0200 Date: Tue, 24 Sep 2013 14:32:12 +0200 From: Ralf Baechle To: Daniel Walker Cc: David Daney , Doug Thompson , linux-edac@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drivers: edac: octeon: fix lack of opstate_init Message-ID: <20130924123212.GD21257@linux-mips.org> References: <1379717202-26990-1-git-send-email-dwalker@fifo99.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1379717202-26990-1-git-send-email-dwalker@fifo99.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37936 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Sep 20, 2013 at 03:46:40PM -0700, Daniel Walker wrote: > If the opstate_init() isn't called the driver won't start properly. > > I just added it in what appears to be an appropriate place. > > Signed-off-by: Daniel Walker Makes sense. Unfortunately :-) Acked-by: Ralf Baechle EDAC folks - I can funnel this patch through my tree or leave that to you, whatever you prefer. Same for Daniel's other patch. Ralf