From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: False positive in checkpatch
Date: Tue, 24 Sep 2013 07:03:05 -0700 [thread overview]
Message-ID: <20130924140305.GZ9093@linux.vnet.ibm.com> (raw)
In-Reply-To: <1379996467.3575.67.camel@joe-AO722>
On Mon, Sep 23, 2013 at 09:21:07PM -0700, Joe Perches wrote:
> On Mon, 2013-09-23 at 15:59 -0700, Paul E. McKenney wrote:
> > Hello!
> >
> > The checkpatch.pl script complains as follows:
> >
> > ERROR: need consistent spacing around '*' (ctx:WxB)
> > #57: FILE: include/linux/rcupdate.h:564:
> > + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \
> >
> > Of course, the two uses of '*' are doing different things, so it should
> > be OK for the spacing to be different.
> >
> > Could you please fix this?
> >
> > Thanx, Paul
> >
>
> Hi Paul.
>
> Try this patch: https://lkml.org/lkml/2013/9/2/428
>
> Andy? Can you verify this suggested patch please?
That does it, thank you! And it does look like this patch was directed
precisely at this patch. ;-)
Thanx, Paul
next prev parent reply other threads:[~2013-09-24 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 22:59 False positive in checkpatch Paul E. McKenney
2013-09-24 4:21 ` Joe Perches
2013-09-24 14:03 ` Paul E. McKenney [this message]
2013-09-24 15:13 ` Andy Whitcroft
2013-09-24 15:45 ` Paul E. McKenney
2013-09-24 14:24 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924140305.GZ9093@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.