From: Oleg Nesterov <oleg@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, security@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] kthread: Make kthread_create() killable.
Date: Tue, 24 Sep 2013 18:38:11 +0200 [thread overview]
Message-ID: <20130924163811.GA4036@redhat.com> (raw)
In-Reply-To: <201309250017.HBG57846.VFOStOFFOLQJHM@I-love.SAKURA.ne.jp>
On 09/25, Tetsuo Handa wrote:
>
> Subject: [PATCH] kthread: make kthread_create() killable
The patch looks correct... although I'll try to reread it later ;)
Minor nit, since you are sending the new version anyway...
> + if (unlikely(wait_for_completion_killable(&done))) {
> + /*
> + * If I was SIGKILLed before kthreadd (or new kernel thread)
> + * calls complete(), leave the cleanup of this structure to
> + * that thread.
> + */
> + if (xchg(&create->done, NULL))
> + return ERR_PTR(-ENOMEM);
ENOMEM? Perhaps EINTR makes more sense.
Oleg.
next prev parent reply other threads:[~2013-09-24 16:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201309132318.HEC05218.OtVOFOFMLJHFQS@I-love.SAKURA.ne.jp>
2013-09-14 16:05 ` [PATCH] kthread: Make kthread_create() killable Oleg Nesterov
2013-09-14 23:46 ` Tetsuo Handa
2013-09-15 16:39 ` Oleg Nesterov
2013-09-16 0:53 ` [PATCH v2] " Tetsuo Handa
2013-09-23 23:07 ` Andrew Morton
2013-09-24 15:17 ` [PATCH v3] " Tetsuo Handa
2013-09-24 16:38 ` Oleg Nesterov [this message]
2013-09-25 21:05 ` David Rientjes
2013-09-26 2:59 ` Tetsuo Handa
2013-09-26 18:53 ` David Rientjes
2013-09-28 7:18 ` Tetsuo Handa
2013-09-30 21:57 ` David Rientjes
2013-10-01 13:20 ` Tetsuo Handa
2013-10-02 7:06 ` David Rientjes
2013-10-02 13:44 ` Tetsuo Handa
[not found] ` <201309152038.DDJ59271.OJMOHLFtSFOQVF@I-love.SAKURA.ne.jp>
2013-09-15 16:55 ` [PATCH] " Oleg Nesterov
2013-09-16 7:25 ` [PATCH] coredump: Make startup of coredump to pipe killable Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924163811.GA4036@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.