From: Oleg Nesterov <oleg@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: John Johansen <john.johansen@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apparmor: remove the "task" arg from may_change_ptraced_domain()
Date: Tue, 24 Sep 2013 18:44:42 +0200 [thread overview]
Message-ID: <20130924164442.GB4036@redhat.com> (raw)
In-Reply-To: <20130923215214.GV13968@madcap2.tricolour.ca>
On 09/23, Richard Guy Briggs wrote:
>
> On Mon, Sep 16, 2013 at 04:20:35PM +0200, Oleg Nesterov wrote:
> > Unless task == current ptrace_parent(task) is not safe even under
> > rcu_read_lock() and most of the current users are not right.
>
> Could you point to an explanation of this?
If this task exits before rcu_read_lock() ->parent can point to the
already freed/reused memory.
(in the long term we should probably clear
->parent/real_parent/group_leader/more in __unhash_process(), but
lets not discuss this right now ;)
> (Did you send a patch to fix the selinux hook?)
No, sorry, I was sick. Will do.
> Acked-by: Richard Guy Briggs <rgb@redhat.com>
Thanks!
Oleg.
next prev parent reply other threads:[~2013-09-24 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:20 [PATCH] apparmor: remove the "task" arg from may_change_ptraced_domain() Oleg Nesterov
2013-09-16 15:10 ` Oleg Nesterov
2013-09-16 17:01 ` John Johansen
2013-09-23 21:52 ` Richard Guy Briggs
2013-09-24 16:44 ` Oleg Nesterov [this message]
2013-09-26 13:25 ` Richard Guy Briggs
-- strict thread matches above, loose matches on Subject: below --
2013-12-18 19:43 Richard Guy Briggs
2013-12-18 20:19 ` [PATCH] apparmor: remove the "task" arg from may_change_ptraced_domain() Oleg Nesterov
2013-12-20 4:36 ` Richard Guy Briggs
2013-12-20 6:22 ` John Johansen
2013-12-20 17:59 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924164442.GB4036@redhat.com \
--to=oleg@redhat.com \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.