All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] perf trace: Add mmap2 handler
Date: Tue, 24 Sep 2013 14:16:26 -0300	[thread overview]
Message-ID: <20130924171626.GC2634@ghostprotocols.net> (raw)
In-Reply-To: <5240DB4D.100@gmail.com>

Em Mon, Sep 23, 2013 at 06:22:37PM -0600, David Ahern escreveu:
> Arnaldo:
> 
> I see this is you perf core tree; the problem exists in Linus' tree
> so it is needed in your urgent tree as well.

Sure, reproduced the segfault, cherry picked this patch from perf/core,
segfault fixes, thanks.

- Arnaldo
 
> David
> 
> On 9/22/13 7:44 PM, David Ahern wrote:
> >5c5e854b changed perf_event__synthesize_mmap_events to generate MMAP2
> >events. Since perf-trace does not have a handler for it it dies with a
> >segfault when trying to process files:
> >
> >perf trace -i /tmp/perf.data
> >Segmentation fault
> >
> >Signed-off-by: David Ahern <dsahern@gmail.com>
> >---
> >  tools/perf/builtin-trace.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> >index 9c7f017..f61c968 100644
> >--- a/tools/perf/builtin-trace.c
> >+++ b/tools/perf/builtin-trace.c
> >@@ -1383,6 +1383,7 @@ static int trace__replay(struct trace *trace)
> >
> >  	trace->tool.sample	  = trace__process_sample;
> >  	trace->tool.mmap	  = perf_event__process_mmap;
> >+	trace->tool.mmap2	  = perf_event__process_mmap2;
> >  	trace->tool.comm	  = perf_event__process_comm;
> >  	trace->tool.exit	  = perf_event__process_exit;
> >  	trace->tool.fork	  = perf_event__process_fork;
> >

  reply	other threads:[~2013-09-24 17:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23  1:44 [PATCH 0/5] perf tool: Various fixes and version 2 on clock_gettime David Ahern
2013-09-23  1:44 ` [PATCH 1/5] perf trace: Handle MSG_WAITFORONE not defined David Ahern
2013-10-15  5:28   ` [tip:perf/core] " tip-bot for David Ahern
2013-09-23  1:44 ` [PATCH 2/5] perf tool: Explicitly add libdl dependency David Ahern
2013-09-25 13:00   ` David Ahern
2013-09-25 18:31   ` [tip:perf/urgent] perf tools: " tip-bot for David Ahern
2013-09-23  1:44 ` [PATCH 3/5] perf trace: Add mmap2 handler David Ahern
2013-09-24  0:22   ` David Ahern
2013-09-24 17:16     ` Arnaldo Carvalho de Melo [this message]
2013-09-25 18:30   ` [tip:perf/urgent] " tip-bot for David Ahern
2013-09-23  1:44 ` [PATCH 4/5] perf tool: Add default handler for mmap2 events David Ahern
2013-10-08 10:40   ` [tip:perf/urgent] perf tools: " tip-bot for David Ahern
2013-09-23  1:45 ` [PATCH 5/5] perf trace: Add beautifier for clock_gettime's clk_id argument - v2 David Ahern
2013-10-15  5:27   ` [tip:perf/core] perf trace: Add beautifier for clock_gettime' s clk_id argument tip-bot for David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130924171626.GC2634@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.