From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] ARM: mxs: tools: Use mkimage for BootStream generation
Date: Tue, 24 Sep 2013 18:51:36 +0200 [thread overview]
Message-ID: <201309241851.36836.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrrmg=JUt+TYoXG06_X3DprTkfZKMgaodvDXUGy_KkT7w@mail.gmail.com>
Dear Otavio Salvador,
> On Tue, Sep 24, 2013 at 1:28 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Tue, Sep 24, 2013 at 12:39 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Now that mkimage can generate an BootStream for i.MX23 and i.MX28,
> >> > use the mkimage as a default tool to generate the BootStreams instead
> >> > of the elftosb tool. This cuts out another obscure dependency.
> >> >
> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >>
> >> ..
> >>
> >> > # Specify the target for use in elftosb call
> >> >
> >> > -ELFTOSB_TARGET-$(CONFIG_MX23) = imx23
> >> > -ELFTOSB_TARGET-$(CONFIG_MX28) = imx28
> >> > +MKIMAGE_TARGET-$(CONFIG_MX23) = mx23
> >> > +MKIMAGE_TARGET-$(CONFIG_MX28) = mx28
> >> >
> >> > -$(OBJTREE)/u-boot.bd:
> >> > $(SRCTREE)/$(CPUDIR)/$(SOC)/u-boot-$(ELFTOSB_TARGET-y).bd
> >> > +$(OBJTREE)/mxsimage.cfg:
> >> > $(SRCTREE)/$(CPUDIR)/$(SOC)/mxsimage.$(MKIMAGE_TARGET-y).cfg
> >> >
> >> > sed "s at OBJTREE@$(OBJTREE)@g" $^ > $@
> >>
> >> This is clearly a mxsimage thing; I do believe MXSIMAGE_TARGET is more
> >> clear.
> >
> > Please read the patch again, the tool that is invoked is called "mkimage"
> > . I disagree.
>
> But it is used to generate the mxsimage.cfg in
> .../mxsimage.$(MKIMAGE_TARGET-y).cfg
>
> So it is really an mxsimage thing.
>
> For something named MKIMAGE_TARGET I would expect it being in the mkimage
> call.
IFF you look at the pattern above (-ELFTOSB -> +MKIMAGE), you can see the name
of the variable contains the name of the tool. I want to stick with MKIMAGE_
here.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-24 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 15:39 [U-Boot] [PATCH v3] ARM: mxs: tools: Use mkimage for BootStream generation Marek Vasut
2013-09-24 16:13 ` Otavio Salvador
2013-09-24 16:28 ` Marek Vasut
2013-09-24 16:37 ` Otavio Salvador
2013-09-24 16:51 ` Marek Vasut [this message]
2013-10-10 15:13 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309241851.36836.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.