From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error.
Date: Wed, 25 Sep 2013 10:31:08 +1000 [thread overview]
Message-ID: <20130925003108.GF26872@dastard> (raw)
In-Reply-To: <20130924205949.GK1935@sgi.com>
On Tue, Sep 24, 2013 at 03:59:49PM -0500, Ben Myers wrote:
> Hi Dave,
>
> On Wed, Sep 25, 2013 at 06:32:32AM +1000, Dave Chinner wrote:
> > On Tue, Sep 24, 2013 at 10:33:24AM -0500, Ben Myers wrote:
> > > ...but it looks like your fix is in xfs_bdstrat_cb, which wouldn't have been
> > > involved in the stack you posted above. What am I missing?
> >
> > That the first hunk that changes xfs_bioerror_relse() fixes the bug
> > that caused the assert failure through xfsbdstrat().
>
> *blink*
>
> All I see in that first hunk are changes to comments. The second hunk seems to
> contain the only functional change, highlighted above.
You are right - it should not be reliably fixing the failure I'm
seeing. I'm sure there was something else in this patch originally -
I'll go back and check.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-25 0:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 6:01 [PATCH 0/5] xfs: fixes for 3.12-rc3 Dave Chinner
2013-09-24 6:01 ` [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error Dave Chinner
2013-09-24 15:31 ` Mark Tinguely
2013-09-24 15:33 ` Ben Myers
2013-09-24 20:32 ` Dave Chinner
2013-09-24 20:59 ` Ben Myers
2013-09-25 0:31 ` Dave Chinner [this message]
2013-09-24 6:01 ` [PATCH 2/5] xfs: lock the AIL before removing the buffer item Dave Chinner
2013-09-24 16:12 ` Mark Tinguely
2013-09-24 6:01 ` [PATCH 3/5] xfs: asserting lock not held during freeing not valid Dave Chinner
2013-09-24 17:17 ` Mark Tinguely
2013-09-24 6:01 ` [PATCH 4/5] xfs: fix XFS_IOC_FREE_EOFBLOCKS definition Dave Chinner
2013-09-24 16:13 ` Mark Tinguely
2013-09-24 6:01 ` [PATCH 5/5] xfs: log recovery lsn ordering needs uuid check Dave Chinner
2013-09-24 17:14 ` Ben Myers
2013-09-24 17:46 ` [PATCH 0/5] xfs: fixes for 3.12-rc3 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925003108.GF26872@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.