From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VOdJP-00072j-FN
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 20:50:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VOdJF-0007qM-QG
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 20:50:39 -0400
Received: from e8.ny.us.ibm.com ([32.97.182.138]:41070)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1VOdJF-0007q6-AX
	for qemu-devel@nongnu.org; Tue, 24 Sep 2013 20:50:29 -0400
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Tue, 24 Sep 2013 20:50:28 -0400
Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com
	[9.57.198.25])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id DB69EC90043
	for <qemu-devel@nongnu.org>; Tue, 24 Sep 2013 20:50:24 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r8P0oOOE62980268
	for <qemu-devel@nongnu.org>; Wed, 25 Sep 2013 00:50:25 GMT
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r8P0oOAW003872
	for <qemu-devel@nongnu.org>; Tue, 24 Sep 2013 20:50:24 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <cover.1377693391.git.amit.shah@redhat.com>
References: <cover.1377693391.git.amit.shah@redhat.com>
Message-ID: <20130925005023.25429.77400@loki>
Date: Tue, 24 Sep 2013 19:50:23 -0500
Subject: Re: [Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Hans de Goede <hdegoede@redhat.com>

Quoting Amit Shah (2013-08-28 07:37:19)
> This series fixes a segfault when a frontend is detached from a
> chardev while the chardev had a pending callback registered.  Further
> details in patch 3.
> =

> Please review.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

Ping for 1.6.1

> =

> v3:
>  * fix whitespace issues in patch 1
> v2:
>  * Move tag property to CharDriverState to simplify everything (Gerd)
> =

> Amit Shah (3):
>   char: move backends' io watch tag to CharDriverState
>   char: use common function to disable callbacks on chardev close
>   char: remove watch callback on chardev detach from frontend
> =

>  include/sysemu/char.h |  1 +
>  qemu-char.c           | 82 +++++++++++++++++++--------------------------=
------
>  2 files changed, 32 insertions(+), 51 deletions(-)
> =

> -- =

> 1.8.3.1