From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laine Stump <laine@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex
Date: Wed, 25 Sep 2013 10:01:16 +0300 [thread overview]
Message-ID: <20130925070116.GA5436@redhat.com> (raw)
In-Reply-To: <524162DE.1080705@redhat.com>
On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote:
> When I added support for the Q35-based machinetypes to libvirt, I
> specifically prohibited attaching any PCI devices (with the exception of
> graphics controllers) to the PCIe root complex,
That's wrong I think. Anything attached to RC is an integrated
endpoint, and these can be PCI devices.
> and had planned to
> prevent attaching them to PCIe root ports (ioh3420 device) and PCIe
> downstream switch ports (xio-3130 device) as well. I did this because,
> even though qemu currently allows attaching a normal PCI device in any
> of these three places, the restriction exists for real hardware and I
> didn't see any guarantee that qemu wouldn't add the restriction in the
> future in order to more closely emulate real hardware.
>
> However, since I did that, I've learned that many of the qemu "pci"
> devices really should be considered as "pci or pcie". Gerd Hoffman lists
> some of these cases in a bug he filed against libvirt:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1003983
>
> I would like to loosen up the restrictions in libvirt, but want to make
> sure that I don't allow something that could later be forbidden by qemu
> (thus creating a compatibility problem during upgrades). Beyond Gerd's
> specific requests to allow ehci, uhci, and hda controllers to attach to
> PCIe ports, are there any other devices that I specifically should or
> shouldn't allow? (I would rather be conservative in what I allow - it's
> easy to allow more things later, but nearly impossible to revoke
> permission once it's been allowed).
IMO, we really need to grow an interface to query this kind of thing.
--
MST
next prev parent reply other threads:[~2013-09-25 6:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 10:01 [Qemu-devel] Attaching PCI devices to the PCIe root complex Laine Stump
2013-09-25 7:01 ` Michael S. Tsirkin [this message]
2013-09-25 8:48 ` Marcel Apfelbaum
2013-09-25 8:59 ` Michael S. Tsirkin
2013-10-02 8:53 ` Paolo Bonzini
2013-10-02 9:28 ` Michael S. Tsirkin
2013-09-25 9:39 ` Laine Stump
2013-09-25 10:00 ` Michael S. Tsirkin
2013-09-25 10:14 ` Laine Stump
2013-09-25 10:56 ` Michael S. Tsirkin
2013-09-25 10:58 ` Michael S. Tsirkin
2013-09-27 17:06 ` Markus Armbruster
2013-09-28 18:12 ` Michael S. Tsirkin
2013-09-30 9:55 ` Markus Armbruster
2013-09-30 10:44 ` Laine Stump
2013-09-30 10:48 ` Michael S. Tsirkin
2013-09-30 16:01 ` Gerd Hoffmann
2013-09-30 16:06 ` Michael S. Tsirkin
2013-10-01 21:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925070116.GA5436@redhat.com \
--to=mst@redhat.com \
--cc=laine@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.