From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum
Date: Wed, 25 Sep 2013 16:24:32 +0100 [thread overview]
Message-ID: <20130925152432.GY13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1380047934.3575.100.camel@joe-AO722>
On Tue, Sep 24, 2013 at 11:38:54AM -0700, Joe Perches wrote:
> Checkpatch doesn't currently find CamelCase definitions
> of structs, unions or enums.
>
> Add that ability.
Fix your regex. As it is, it catches the things that are not camelcase
by any stretch of definition - [A-Z][a-z]+ will get caught by that and
it's neither camelcase nor something that ought to be discouraged for
e.g. enum member names.
CamelCase refers to caps in the middle of a compound, used to visually
separate them.
next prev parent reply other threads:[~2013-09-25 15:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 18:38 [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum Joe Perches
2013-09-25 15:24 ` Al Viro [this message]
2013-09-25 15:35 ` Joe Perches
2013-09-25 16:19 ` Al Viro
2013-09-25 17:27 ` Alexander Holler
2013-09-25 19:22 ` Joe Perches
2013-09-25 19:30 ` Theodore Ts'o
2013-09-25 19:48 ` Joe Perches
2013-09-25 19:54 ` Alexander Holler
2013-09-25 20:03 ` Andrew Morton
2013-09-25 20:23 ` Al Viro
2013-09-26 1:10 ` Theodore Ts'o
2013-09-26 1:13 ` Andrew Morton
2013-09-25 20:11 ` Al Viro
2013-09-26 0:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925152432.GY13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.