From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: jigsaw <jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Add support for 82599 Tx->Rx loopback operation.
Date: Wed, 25 Sep 2013 16:47:26 +0200 [thread overview]
Message-ID: <201309251647.26757.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1FD9B82B8BF2CF418D9A1000154491D973F50C7E-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
25/09/2013 16:12, Venkatesan, Venky :
> I for one would prefer that the changes not really modify any files in the
> librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from
> the BSD driver baseline, and any changes will make future merges of newer
> code more challenging. The changes should be limited to files in the
> librte_pmd_ixgbe directory (and ethdev).
I agree with Venky.
The poll-mode drivers e1000 and ixgbe are based on drivers located in
subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use
the base drivers without modifying it.
So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c.
The coding rules are not written. If needed, we could add a file for it.
Thanks for your patch
--
Thomas
next prev parent reply other threads:[~2013-09-25 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 19:16 [PATCH] Add support for 82599 Tx->Rx loopback operation Qinglai Xiao
[not found] ` <1379963780-5044-1-git-send-email-jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-25 13:11 ` Ivan Boule
[not found] ` <5242E105.6030200-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-09-25 13:56 ` jigsaw
[not found] ` <CAHVfvh5bRK6O5PGv+meBmXospNy10vtnSiWWvHzyF841wAtkwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-25 14:12 ` Venkatesan, Venky
[not found] ` <1FD9B82B8BF2CF418D9A1000154491D973F50C7E-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-09-25 14:38 ` jigsaw
[not found] ` <CAHVfvh4X-Wxf4dj3E+Y0sxMO6LPpT_dYA4ZhdP7rkB0gq0u-0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-25 15:47 ` Venkatesan, Venky
[not found] ` <1FD9B82B8BF2CF418D9A1000154491D973F50FCF-P5GAC/sN6hlcIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2013-09-25 16:59 ` jigsaw
[not found] ` <CAHVfvh422=qg2yQ+gea95noRmwW2AFSb8GeWOUfsoKTDR6egGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-25 17:37 ` Venkatesan, Venky
2013-09-26 7:27 ` Ivan Boule
2013-09-25 14:47 ` Thomas Monjalon [this message]
[not found] ` <201309251647.26757.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-09-25 14:56 ` jigsaw
2013-09-25 15:04 ` Ivan Boule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309251647.26757.thomas.monjalon@6wind.com \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.