From: "J. Bruce Fields" <bfields@fieldses.org>
To: David Howells <dhowells@redhat.com>
Cc: Trond.Myklebust@netapp.com, olof@lixom.net,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in
Date: Thu, 26 Sep 2013 11:21:26 -0400 [thread overview]
Message-ID: <20130926152125.GD704@fieldses.org> (raw)
In-Reply-To: <20130926144502.29424.21633.stgit@warthog.procyon.org.uk>
On Thu, Sep 26, 2013 at 03:45:02PM +0100, David Howells wrote:
>
>
> Here's a series of patches to make SunRPC/NFS use no_printk() to implement its
> null dfprintk() macro (ie. when RPC_DEBUG is disabled). This prevents 'unused
> variable' errors from occurring when a variable is set only for use in
> debugging statements and renders RPC/NFS_IFDEBUG unnecessary.
Does this patch series fix any actual warnings? Or does it just change
the way that we prevent the warnings?
Whatever, I've got no opinion--ACK for any parts that touch code I
maintain....
--b.
>
> David
> ---
> David Howells (4):
> SunRPC: Use the standard varargs macro method for dfprintk() and co.
> SunRPC: Declare and use rpc_task_pid() to wrap task->tk_pid
> SunRPC: Use no_printk() for the null dprintk() and dfprintk()
> SunRPC: Kill RPC_IFDEBUG() and NFS_IFDEBUG()
>
>
> fs/lockd/clntproc.c | 2 +
> fs/lockd/svc.c | 6 ++-
> fs/lockd/svc4proc.c | 2 +
> fs/lockd/svclock.c | 6 ++-
> fs/lockd/svcproc.c | 2 +
> fs/nfs/direct.c | 6 ++-
> fs/nfs/fscache.c | 2 +
> fs/nfs/nfs4filelayout.c | 8 ++--
> fs/nfs/nfs4proc.c | 2 +
> fs/nfs/read.c | 4 +-
> fs/nfs/write.c | 8 ++--
> fs/nfsd/nfs4proc.c | 6 +--
> fs/nfsd/nfsfh.c | 10 +++---
> include/linux/nfs_fs.h | 2 -
> include/linux/sunrpc/debug.h | 39 ++++++++++------------
> include/linux/sunrpc/sched.h | 20 ++++++++---
> include/trace/events/sunrpc.h | 8 ++--
> net/sunrpc/auth.c | 18 +++++-----
> net/sunrpc/auth_gss/auth_gss.c | 20 ++++++-----
> net/sunrpc/clnt.c | 72 ++++++++++++++++++++--------------------
> net/sunrpc/rpcb_clnt.c | 34 +++++++++----------
> net/sunrpc/sched.c | 39 +++++++++-------------
> net/sunrpc/svcsock.c | 33 +++++++++++-------
> net/sunrpc/xprt.c | 30 ++++++++---------
> net/sunrpc/xprtsock.c | 2 +
> 25 files changed, 194 insertions(+), 187 deletions(-)
>
next prev parent reply other threads:[~2013-09-26 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:45 [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in David Howells
2013-09-26 14:45 ` [PATCH 1/4] SunRPC: Use the standard varargs macro method for dfprintk() and co David Howells
2013-09-26 14:45 ` [PATCH 2/4] SunRPC: Declare and use rpc_task_pid() to wrap task->tk_pid David Howells
2013-09-26 14:48 ` David Howells
2013-09-26 14:45 ` [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk() David Howells
2013-09-26 15:30 ` Joe Perches
2013-09-26 15:35 ` David Howells
2013-09-26 15:38 ` Joe Perches
2013-09-26 15:42 ` David Howells
2013-09-26 15:42 ` Myklebust, Trond
2013-09-26 14:45 ` [PATCH 4/4] SunRPC: Kill RPC_IFDEBUG() and NFS_IFDEBUG() David Howells
2013-09-26 15:21 ` J. Bruce Fields [this message]
2013-09-26 15:23 ` [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in Myklebust, Trond
2013-09-26 15:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926152125.GD704@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.