All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Davidlohr Bueso <davidlohr@hp.com>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	msharbiani@twitter.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/reboot] x86/reboot: Remove the duplicate C6100 entry in the reboot quirks list
Date: Fri, 27 Sep 2013 07:51:51 +0200	[thread overview]
Message-ID: <20130927055151.GD6597@gmail.com> (raw)
In-Reply-To: <5244A0E2.3080902@zytor.com>


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 09/26/2013 01:59 PM, Davidlohr Bueso wrote:
> >> -	},
> >> -	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
> >> -		.callback = set_pci_reboot,
> >> -		.ident = "Dell PowerEdge C6100",
> >> -		.matches = {
> >>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> >>  			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> >>  		},
> > 
> > Hmm, I think we should be keeping the 'Dell Inc.' part instead of just
> > 'Dell' - at least the rest of the entries use the same string:
> > 
> 
> The point is that some of the machines just has "Dell" in their vendor
> string.

Yes, so if then the argument could be made that all the other entries 
should probably be changed to 'Dell' as well.

This is yet another reminder that DMI matches are such a fragile method 
...

Thanks,

	Ingo

      reply	other threads:[~2013-09-27  5:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 17:30 [PATCH] Patch x86: Remove the duplicate C6100 entry in quirky motherboard boot list Masoud Sharbiani
2013-09-26 18:58 ` [tip:x86/reboot] x86/reboot: Remove the duplicate C6100 entry in the reboot quirks list tip-bot for Masoud Sharbiani
2013-09-26 20:59   ` Davidlohr Bueso
2013-09-26 21:02     ` H. Peter Anvin
2013-09-27  5:51       ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927055151.GD6597@gmail.com \
    --to=mingo@kernel.org \
    --cc=davidlohr@hp.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=msharbiani@twitter.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.