All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: kernel: traps: Remove useless BUG_ON()
@ 2013-09-26  9:35 ` Markos Chandras
  0 siblings, 0 replies; 5+ messages in thread
From: Markos Chandras @ 2013-09-26  9:35 UTC (permalink / raw)
  To: linux-mips; +Cc: Markos Chandras

Checking for n<0 && n>9 makes no sense because it can never
be true. Moreover, we can have up to 64 vectored interrupts
so BUG_ON(n>9) was wrong anyway.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
 arch/mips/kernel/traps.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 524841f..f2ae9cb 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -1554,7 +1554,6 @@ static void *set_vi_srs_handler(int n, vi_handler_t addr, int srs)
 	unsigned char *b;
 
 	BUG_ON(!cpu_has_veic && !cpu_has_vint);
-	BUG_ON((n < 0) && (n > 9));
 
 	if (addr == NULL) {
 		handler = (unsigned long) do_default_vi;
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-09-27 12:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-26  9:35 [PATCH] MIPS: kernel: traps: Remove useless BUG_ON() Markos Chandras
2013-09-26  9:35 ` Markos Chandras
2013-09-26 16:08 ` Ralf Baechle
2013-09-26 16:23   ` MIPS: PowerTV: Remove support code Ralf Baechle
2013-09-27 12:43   ` [PATCH] MIPS: kernel: traps: Remove useless BUG_ON() Ralf Baechle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.