From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: xtables_ipmask_to_numeric incorrect with non-CIDR masks
Date: Fri, 27 Sep 2013 16:30:52 +0200 [thread overview]
Message-ID: <20130927143052.GA14714@localhost> (raw)
In-Reply-To: <20130926160658.GA12333@home>
On Thu, Sep 26, 2013 at 09:06:58AM -0700, Phil Oester wrote:
> As pointed out by Peter Hoelsken, rules created with non-standard masks such as
> 0.255.0.0, 0.0.255.0, etc. are displayed when output with iptables -L in CIDR
> notation as -1. This is because the cidr variable in xtables_ipmask_to_numeric
> is unsigned, and the return value of -1 from xtables_ipmask_to_cidr is therefore
> converted to 4294967295. Add a cast to workaround the issue.
>
> This closes netfilter bugzilla #854.
Applied, thanks Phil!
prev parent reply other threads:[~2013-09-27 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 16:06 [PATCH] iptables: xtables_ipmask_to_numeric incorrect with non-CIDR masks Phil Oester
2013-09-27 14:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927143052.GA14714@localhost \
--to=pablo@netfilter.org \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.