From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: Code stereo layouts as an enum in the mode structure
Date: Fri, 27 Sep 2013 18:36:05 +0300 [thread overview]
Message-ID: <20130927153605.GH14385@intel.com> (raw)
In-Reply-To: <1380280310-903-1-git-send-email-damien.lespiau@intel.com>
On Fri, Sep 27, 2013 at 12:11:47PM +0100, Damien Lespiau wrote:
> Daniel noticed that it wasn't very smart to keep using one bit per stereo
> layout now that we don't have to or them. It's a nice final touch to the new
> stereo mode API extension that we should fix before committing to it.
Assuming you still trust me even though I didn't see this possibility
during my review of the original series :)
For the series:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-09-27 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 11:11 Code stereo layouts as an enum in the mode structure Damien Lespiau
2013-09-27 11:11 ` [PATCH 1/3] drm: Code stereo layouts as an enum rather than a bit field Damien Lespiau
2013-09-27 11:11 ` [PATCH 2/3] drm: Revert "drm: Reject modes with more than 1 stereo flags set" Damien Lespiau
2013-09-27 11:11 ` [PATCH 3/3] drm: Reject stereo modes with an unknown layout Damien Lespiau
2013-09-27 15:36 ` Ville Syrjälä [this message]
2013-09-27 19:41 ` Code stereo layouts as an enum in the mode structure Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927153605.GH14385@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=damien.lespiau@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.