All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix apparent cut-n-paste mistake in Dell reboot workaround.
Date: Fri, 27 Sep 2013 16:19:51 -0400	[thread overview]
Message-ID: <20130927201951.GA22836@redhat.com> (raw)
In-Reply-To: <5245E7B1.2000408@zytor.com>

On Fri, Sep 27, 2013 at 03:16:49PM -0500, H. Peter Anvin wrote:
 > On 09/24/2013 07:13 PM, Dave Jones wrote:
 > > This seems to have been copied from the Optiplex 990 entry above, but somoene
 > > forgot to change the ident text.
 > > 
 > > Signed-off-by: Dave Jones <davej@fedoraproject.org>
 > > 
 > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
 > > index f6835d8..ea2aaca 100644
 > > --- a/arch/x86/kernel/reboot.c
 > > +++ b/arch/x86/kernel/reboot.c
 > > @@ -360,7 +360,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
 > >  	},
 > >  	{	/* Handle problems with rebooting on the Precision M6600. */
 > >  		.callback = set_pci_reboot,
 > > -		.ident = "Dell OptiPlex 990",
 > > +		.ident = "Dell Precision M6600",
 > >  		.matches = {
 > >  			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
 > >  			DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
 > > 
 > 
 > It really is starting to feel like *ALL* Dell machines need reboot=pci?

Either that or 'bios'.  The question I have is, of those marked 'bios', does =pci
work too ?  If we knew that was true, I'd probably say yes.

	Dave


  reply	other threads:[~2013-09-27 20:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25  0:13 Fix apparent cut-n-paste mistake in Dell reboot workaround Dave Jones
2013-09-25  7:42 ` [tip:x86/urgent] x86/reboot: " tip-bot for Dave Jones
2013-09-27 20:16 ` H. Peter Anvin
2013-09-27 20:19   ` Dave Jones [this message]
2013-09-27 20:34     ` H. Peter Anvin
2013-09-30  2:57   ` Matthew Garrett
2013-09-30  2:58     ` H. Peter Anvin
2013-09-30  3:06       ` Matthew Garrett
2013-09-30  3:15         ` Dave Airlie
2013-09-30  4:23           ` H. Peter Anvin
2013-09-30  4:32           ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130927201951.GA22836@redhat.com \
    --to=davej@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.