From: Jens Axboe <axboe@kernel.dk>
To: Akhil Bhansali <Akhil.Bhansali@hgst.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
OS Engineering <osengineering@stec-inc.com>,
Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amit Phansalkar <Amit.Phansalkar@hgst.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq'
Date: Fri, 27 Sep 2013 20:47:51 -0600 [thread overview]
Message-ID: <20130928024751.GA5434@kernel.dk> (raw)
In-Reply-To: <5245CA7C.7090306@kernel.dk>
On Fri, Sep 27 2013, Jens Axboe wrote:
> On 09/27/2013 05:26 AM, Akhil Bhansali wrote:
> > Hello Jens,
> >
> > There are few improvements suggested by community for driver:
> > 1. Replacement of custom macros for debug printing. (DPRINTK / VPRINTK).
> > 2. Reformatting of "skd_request_fn" which is too long.
> >
> > Kindly let us know if you see any other changes required before it can be moved to mainline kernel.
>
> Did you forget to attach the patch?
Sorry, I misread that initially. The major eye sore right now is the
PRINTK stuff. The refactor of the request_fn would be a plus. Start with
those two, and I'll take a look and see if we need to do more right now.
--
Jens Axboe
next prev parent reply other threads:[~2013-09-28 2:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5230cf49.xeAraX9UUfBD+Brs%fengguang.wu@intel.com>
2013-09-13 12:59 ` [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq' Akhil Bhansali
2013-09-13 15:25 ` Jens Axboe
2013-09-18 10:05 ` Akhil Bhansali
2013-09-18 14:36 ` Jens Axboe
2013-09-19 12:09 ` Akhil Bhansali
2013-09-23 11:59 ` Akhil Bhansali
2013-09-23 14:20 ` Jens Axboe
2013-09-27 11:26 ` Akhil Bhansali
2013-09-27 18:12 ` Jens Axboe
2013-09-28 2:47 ` Jens Axboe [this message]
2013-09-18 19:24 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130928024751.GA5434@kernel.dk \
--to=axboe@kernel.dk \
--cc=Akhil.Bhansali@hgst.com \
--cc=Amit.Phansalkar@hgst.com \
--cc=Ramprasad.Chinthekindi@hgst.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=osengineering@stec-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.