All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] mtd: Fix function description in part_validate comment
Date: Sat, 28 Sep 2013 15:06:16 +0200	[thread overview]
Message-ID: <20130928150616.0178cb54@e6520eb> (raw)
In-Reply-To: <1380338659-7896-1-git-send-email-otavio@ossystems.com.br>

Hi Otavio,

Le Sat, 28 Sep 2013 00:24:12 -0300,
Otavio Salvador <otavio@ossystems.com.br> a ?crit :

> The part_validate comment had a wrong description of the actions it
> does and referenced to non-existent functions while in fact it calls
> 'part_validate_eraseblock()'.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  common/cmd_mtdparts.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c
> index 3023479..0104285 100644
> --- a/common/cmd_mtdparts.c
> +++ b/common/cmd_mtdparts.c
> @@ -381,10 +381,10 @@ static int part_validate_eraseblock(struct mtdids *id, struct part_info *part)
>  
>  
>  /**
> - * Performs sanity check for supplied partition. Offset and size are verified
> - * to be within valid range. Partition type is checked and either
> - * parts_validate_nor() or parts_validate_nand() is called with the argument
> - * of part.
> + * Performs sanity check for supplied partition. Offset and size are
> + * verified to be within valid range. Partition type is checked and
> + * either part_validate_eraseblock() is called with the argument of

and now you can remove either ;-)

Eric

      parent reply	other threads:[~2013-09-28 13:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-28  3:24 [U-Boot] [PATCH 1/7] mtd: Fix function description in part_validate comment Otavio Salvador
2013-09-28  3:24 ` [U-Boot] [PATCH 2/7] doc: Fix a typo in the description in doc/README.JFFS2_NAND Otavio Salvador
2013-09-28  3:24 ` [U-Boot] [PATCH 3/7] include/linux/fb.h: Add a missing include for 'list.h' Otavio Salvador
2013-09-28 16:46   ` Fabio Estevam
2013-09-28  3:24 ` [U-Boot] [PATCH 4/7] gpio-led: Use __led_set in __led_init code Otavio Salvador
2013-09-28  3:24 ` [U-Boot] [PATCH 5/7] gpio-led: Fix __led_toggle support to first set GPIO as input Otavio Salvador
2013-09-28 13:12   ` Eric Bénard
2013-09-28 16:35     ` Fabio Estevam
2013-09-28 19:05       ` Otavio Salvador
2013-09-28  3:24 ` [U-Boot] [PATCH 6/7] status_led: Add support for inverted LEDs Otavio Salvador
2013-09-28 14:17   ` Benoît Thébaudeau
2013-09-28 16:49     ` Fabio Estevam
2013-09-28 19:08       ` Otavio Salvador
2013-09-29 13:40         ` Benoît Thébaudeau
2013-09-28  3:24 ` [U-Boot] [PATCH 7/7] cmd_led: Add support for inverted BIT leds Otavio Salvador
2013-09-28 13:06 ` Eric Bénard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130928150616.0178cb54@e6520eb \
    --to=eric@eukrea.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.