From: Elad Wexler <elad.wexler@gmail.com>
To: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, elad.wexler@gmail.com
Subject: Re: [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver'
Date: Sun, 29 Sep 2013 01:14:02 +0300 [thread overview]
Message-ID: <20130928221400.GA4630@gmail.com> (raw)
In-Reply-To: <CAFLxGvzWsr7RCtxOcZ2LO1dSmjt0Khr91JAcM_NykCYRtd2R8Q@mail.gmail.com>
On Sat, Sep 28, 2013 at 08:54:55PM +0200, richard -rw- weinberger wrote:
> On Sat, Sep 28, 2013 at 8:14 PM, <elad.wexler@gmail.com> wrote:
> > From: Elad Wexler <elad.wexler@gmail.com>
> >
> > Driver doesn't do anything special in 'module_init'.
> >
> > 'module_platform_init' makes the code more readable.
> >
> > Signed-off-by: Elad Wexler <elad.wexler@gmail.com>
>
> NAK.
>
> By moving to module_platform_init() you make this module unloadable.
> Currently it is unloadable for good reasons.
> The cs5535-mfgpt chip is nasty because it has no reliable reset function.
> Therefore by unloading and loading the module again bad things can happen.
>
I think this HW information should be well documented.
Explaining the reason why it doesn't implemented the 'module_exit'
> --
> Thanks,
> //richard
next prev parent reply other threads:[~2013-09-28 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 18:14 [PATCH] misc: cs5535-mfgpt: Replace 'module_init' with 'module_platform_driver' elad.wexler
2013-09-28 18:54 ` richard -rw- weinberger
2013-09-28 22:14 ` Elad Wexler [this message]
2013-09-28 22:23 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130928221400.GA4630@gmail.com \
--to=elad.wexler@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.