From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: get rid of count from xfs_iomap_write_allocate()
Date: Mon, 30 Sep 2013 08:35:11 +1000 [thread overview]
Message-ID: <20130929223511.GF26872@dastard> (raw)
In-Reply-To: <52480744.10606@oracle.com>
On Sun, Sep 29, 2013 at 06:56:04PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Get rid of function variable count from xfs_iomap_write_allocate() as
> it is unused.
>
> Additionally, checkpatch warn me of the following for this change:
> WARNING: extern prototypes should be avoided in .h files
> +extern int xfs_iomap_write_allocate(struct xfs_inode *, xfs_off_t,
Bah, checkpatch should be considered harmful when run on code that
has been around for years. It's a good guide for new code, but...
$ git grep extern fs/xfs/xfs*h |wc -l
345
$ git grep extern include/linux/*h |wc -l
6878
$
.... and the rule of "consistent with existing coding style" when
adding code to existing files generally trumps any "style errors"
that checkpatch might warn about.
> So this patch also remove all extern function prototypes at xfs_iomap.h
> to suppress it to make this code style in consistent manner in this file.
Anyway, it's a cleanup patch to begin with, and there's only a few
of them, so it's not worth complaining about.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-29 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 10:56 [PATCH] xfs: get rid of count from xfs_iomap_write_allocate() Jeff Liu
2013-09-29 22:35 ` Dave Chinner [this message]
2013-10-01 20:58 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130929223511.GF26872@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.