From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Leblond <eric@regit.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH 1/2] fix IPv6 prefix computation.
Date: Mon, 30 Sep 2013 12:57:15 +0200 [thread overview]
Message-ID: <20130930105715.GA6448@localhost> (raw)
In-Reply-To: <1380448409-19583-2-git-send-email-eric@regit.org>
On Sun, Sep 29, 2013 at 11:53:28AM +0200, Eric Leblond wrote:
> The prefix building algorithm in netlink phase was incorrect in
> IPv6.
>
> For example, when adding the following rule
> nft add rule ip6 nat postrouting ip6 saddr 2::/64 --debug=all
>
> we had:
>
> ip6 nat postrouting 0 0
> [ payload load 16b @ network header + 8 => reg 1 ]
> [ bitwise reg 1 = (reg=1 & 0x00000000 0x99361540 0x00007f8d 0x2e33a1eb ) ^ 0x00000000 0x00000000 0x00000000 0x00000000 ]
> [ cmp eq reg 1 0x00000200 0x00000000 0x00000000 0x00000000 ]
>
> With the patch the result is as expected:
>
> ip6 nat postrouting 0 0
> [ payload load 16b @ network header + 8 => reg 1 ]
> [ bitwise reg 1 = (reg=1 & 0xffffffff 0xffffffff 0x00000000 0x00000000 ) ^ 0x00000000 0x00000000 0x00000000 0x00000000 ]
> [ cmp eq reg 1 0x00000200 0x00000000 0x00000000 0x00000000 ]
Applied, thanks Eric!
next prev parent reply other threads:[~2013-09-30 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 9:53 [nftables PATCH 0/2] IPv6 improvements Eric Leblond
2013-09-29 9:53 ` [nftables PATCH 1/2] fix IPv6 prefix computation Eric Leblond
2013-09-30 10:57 ` Pablo Neira Ayuso [this message]
2013-09-29 9:53 ` [nftables PATCH 2/2] Add support for IPv6 NAT Eric Leblond
2013-09-30 10:57 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930105715.GA6448@localhost \
--to=pablo@netfilter.org \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.