All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] [RFC] ARM: prepare ARMv7-M for MULTIPLATFORM use
Date: Mon, 30 Sep 2013 12:34:25 +0200	[thread overview]
Message-ID: <201309301234.25913.arnd@arndb.de> (raw)
In-Reply-To: <1380534577-15076-4-git-send-email-u.kleine-koenig@pengutronix.de>

On Monday 30 September 2013, Uwe Kleine-K?nig wrote:
> v7-M is a third group that is incompatible with both v4/v5 and v6/v7.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> This behaves strange but I think is robust not to allow broken configs:
> 
> When v4/v5 is selected, v6/v7 and v7m are available for enabling, too.
> When v6/v7 is selected the other choices are disabled
> When v7m is selected only v6/v7 are available for enabling.

The Kconfig stuff all looks good, 

Acked-by: Arnd Bergmann <arnd@arndb.de>


> diff --git a/arch/arm/kernel/entry-v7m.S b/arch/arm/kernel/entry-v7m.S
> index 52b2643..f72ced6 100644
> --- a/arch/arm/kernel/entry-v7m.S
> +++ b/arch/arm/kernel/entry-v7m.S
> @@ -14,8 +14,6 @@
>  #include <asm/thread_notify.h>
>  #include <asm/v7m.h>
>  
> -#include <mach/entry-macro.S>
> -
>  #include "entry-header.S"
>  
>  #ifdef CONFIG_TRACE_IRQFLAGS
> @@ -141,3 +139,7 @@ ENTRY(vector_table)
>  	.rept	64 - 16
>  	.long	__irq_entry		@ 16..64 - External Interrupts
>  	.endr
> +
> +	.globl  handle_arch_irq
> +handle_arch_irq:
> +	.long	0
> -- 
> 1.8.4.rc3

I'm not sure about this part. I guess you should either make it
a separate patch, or describe what it's for in the patch description above.

Also, I'd put all of the text you have in the comment into the actual
changeset text, above the --- line, as others might find that useful
later.

	Arnd

  reply	other threads:[~2013-09-30 10:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30  9:49 [PATCH 0/3] v7-M support using MULTIPLATFORM Uwe Kleine-König
2013-09-30  9:49 ` [PATCH 1/3] ARM: drop !ARCH_MULTIPLATFORM dependency of XIP_KERNEL Uwe Kleine-König
2013-09-30  9:49 ` [PATCH 2/3] ARM: allow MULTIPLATFORM on no-MMU machines Uwe Kleine-König
2013-10-01 10:29   ` Jonathan Austin
2013-09-30  9:49 ` [PATCH 3/3] [RFC] ARM: prepare ARMv7-M for MULTIPLATFORM use Uwe Kleine-König
2013-09-30 10:34   ` Arnd Bergmann [this message]
2013-09-30 16:02     ` Uwe Kleine-König
2013-10-03 20:04     ` Uwe Kleine-König
2013-10-03 22:00 ` [PATCH 0/3] v7-M support using MULTIPLATFORM Russell King - ARM Linux
2013-10-03 22:28   ` Uwe Kleine-König
2013-10-03 23:05     ` Russell King - ARM Linux
2013-10-04  1:46       ` Nicolas Pitre
2013-11-04  8:25         ` Uwe Kleine-König
2013-11-05 11:40           ` Arnd Bergmann
2013-10-04  7:31       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201309301234.25913.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.