From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, wei.liu2@citrix.com, abchak@juniper.net,
xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature
Date: Mon, 30 Sep 2013 10:43:27 -0400 [thread overview]
Message-ID: <20130930144327.GL3106@phenom.dumpdata.com> (raw)
In-Reply-To: <1380532331.1302.9.camel@kazak.uk.xensource.com>
On Mon, Sep 30, 2013 at 10:12:11AM +0100, Ian Campbell wrote:
> On Sat, 2013-09-28 at 15:38 -0400, David Miller wrote:
> > From: Wei Liu <wei.liu2@citrix.com>
> > Date: Sat, 21 Sep 2013 17:05:43 +0100
> >
> > > @@ -1371,7 +1373,8 @@ static struct net_device *xennet_create_dev(struct xenbus_device *dev)
> > > netif_napi_add(netdev, &np->napi, xennet_poll, 64);
> > > netdev->features = NETIF_F_IP_CSUM | NETIF_F_RXCSUM |
> > > NETIF_F_GSO_ROBUST;
> > > - netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO;
> > > + netdev->hw_features = NETIF_F_IP_CSUM | NETIF_F_SG | NETIF_F_TSO |
> > > + NETIF_F_GRO;
> >
> > Please post a new version of this patch with the feedback you've been
> > given integrated, in particular with this part removed because it is
> > not necessary.
> >
> > Ian, please review the patch when Wei posts it.
>
> I will, but note:
> $ ./scripts/get_maintainer.pl -f drivers/net/xen-netfront.c
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> (supporter:XEN HYPERVISOR IN...)
> Jeremy Fitzhardinge <jeremy@goop.org> (supporter:XEN HYPERVISOR IN...)
> xen-devel@lists.xensource.com (moderated list:XEN HYPERVISOR IN...)
> virtualization@lists.linux-foundation.org (open list:XEN HYPERVISOR IN...)
> netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> Strictly speaking I maintain netback not front, so Wei please remember
> to CC the right people (mainly Konrad) as well as me.
Which was Acked:
http://mid.gmane.org/20130924163036.GB13979@phenom.dumpdata.com
>
> BTW I think this separation is a good thing since it keeps changes to
> the protocol "honest". Doesn't matter so much for this particular patch
> since don't think it actually touches the protocol.
>
> Ian.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
prev parent reply other threads:[~2013-09-30 14:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 16:05 [PATCH net-next] xen-netfront: convert to GRO API and advertise this feature Wei Liu
2013-09-22 6:29 ` Jason Wang
2013-09-22 6:29 ` [Xen-devel] " Jason Wang
2013-09-22 12:09 ` Wei Liu
2013-09-22 12:09 ` [Xen-devel] " Wei Liu
2013-09-22 23:04 ` Anirban Chakraborty
2013-09-23 5:02 ` Jason Wang
2013-09-23 6:22 ` annie li
2013-09-23 20:32 ` Anirban Chakraborty
2013-09-23 20:32 ` [Xen-devel] " Anirban Chakraborty
2013-09-23 6:22 ` annie li
2013-09-23 5:02 ` Jason Wang
2013-09-22 23:04 ` Anirban Chakraborty
2013-09-22 14:55 ` Eric Dumazet
2013-09-22 23:09 ` Anirban Chakraborty
2013-09-22 23:09 ` Anirban Chakraborty
2013-09-23 5:58 ` Eric Dumazet
2013-09-23 5:58 ` Eric Dumazet
2013-09-23 20:27 ` Anirban Chakraborty
2013-09-22 14:55 ` Eric Dumazet
2013-09-24 16:30 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-09-24 16:30 ` Konrad Rzeszutek Wilk
2013-09-28 19:38 ` David Miller
2013-09-28 19:38 ` David Miller
2013-09-30 9:12 ` Ian Campbell
2013-09-30 9:12 ` Ian Campbell
2013-09-30 14:43 ` Konrad Rzeszutek Wilk
2013-09-30 14:43 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930144327.GL3106@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=abchak@juniper.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.