From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"liu ping fan" <qemulist@gmail.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet
Date: Mon, 30 Sep 2013 18:58:44 +0300 [thread overview]
Message-ID: <20130930155844.GB10306@redhat.com> (raw)
In-Reply-To: <52499D33.9020603@redhat.com>
On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote:
> Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto:
> > I was really only talking about q35 here.
> > I thought it's ugly that users can control intcap
> > directly. Can object_set_property be used after
> > qdev_try_create?
>
> Yes, after that and before qdev_init. This is how Ping Fan is doing
> PIIX right now.
>
> > PIIX has another issue:
> > the default value in hpet is really Q35 specific,
> > that's also kind of ugly, isn't it?
>
> Yeah, perhaps it is. So are you suggesting the default to be 4 (GSI2 only)?
>
> Paolo
I suggest it fails unless caller set the property.
next prev parent reply other threads:[~2013-09-30 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 3:25 [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet Liu Ping Fan
2013-09-12 3:25 ` [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS Liu Ping Fan
2013-09-28 19:52 ` Michael S. Tsirkin
2013-09-29 3:25 ` liu ping fan
2013-09-29 4:20 ` Michael S. Tsirkin
2013-09-30 8:04 ` liu ping fan
2013-09-12 3:25 ` [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet Liu Ping Fan
2013-09-28 19:56 ` Michael S. Tsirkin
2013-09-29 3:49 ` liu ping fan
2013-09-29 4:15 ` Michael S. Tsirkin
2013-09-30 8:02 ` liu ping fan
2013-09-30 9:06 ` Michael S. Tsirkin
2013-09-30 9:06 ` Paolo Bonzini
2013-09-30 9:30 ` Michael S. Tsirkin
2013-09-30 15:48 ` Paolo Bonzini
2013-09-30 15:58 ` Michael S. Tsirkin [this message]
2013-10-09 3:27 ` liu ping fan
2013-10-09 7:24 ` Michael S. Tsirkin
2013-10-09 7:41 ` Paolo Bonzini
2013-10-09 8:01 ` Michael S. Tsirkin
2013-10-09 8:41 ` Paolo Bonzini
2013-09-12 3:25 ` [Qemu-devel] [PATCH v5 3/5] PC: use qdev_xx to create hpet instead of sysbus_create_xx Liu Ping Fan
2013-09-12 3:25 ` [Qemu-devel] [PATCH v5 4/5] PC: differentiate hpet's interrupt capability on piix and q35 Liu Ping Fan
2013-09-12 3:25 ` [Qemu-devel] [PATCH v5 5/5] PC-1.6: add compatibility for hpet intcap on pc-q35-1.6 Liu Ping Fan
2013-09-12 6:29 ` [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet Paolo Bonzini
2013-09-12 7:49 ` liu ping fan
2013-09-25 6:27 ` liu ping fan
2013-09-25 15:59 ` Paolo Bonzini
2013-09-26 15:45 ` Mike Day
2013-09-26 15:48 ` Mike Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930155844.GB10306@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.