From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756068Ab3I3QLy (ORCPT ); Mon, 30 Sep 2013 12:11:54 -0400 Received: from merlin.infradead.org ([205.233.59.134]:45913 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945Ab3I3QLx (ORCPT ); Mon, 30 Sep 2013 12:11:53 -0400 Date: Mon, 30 Sep 2013 18:11:41 +0200 From: Peter Zijlstra To: Linus Torvalds Cc: Ingo Molnar , Oleg Nesterov , Paul McKenney , Thomas Gleixner , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH 0/6] sched, wait: Collapse __wait_event macros -v4 Message-ID: <20130930161141.GF3081@twins.programming.kicks-ass.net> References: <20130930152242.207382649@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 30, 2013 at 08:50:04AM -0700, Linus Torvalds wrote: > On Mon, Sep 30, 2013 at 8:22 AM, Peter Zijlstra wrote: > > > > Compile and boot tested on x86_64. > > Btw, I assume the odd binary size reduction is gone now, and code > generation is generally identical? Over patch 4; yes. Patches 1-3 generate different kernels, esp patch 2 has a large drop in size, 5 too is invariant. Patch 6 however increases code size again, but then it actually changes the generated code so that's somewhat expected. But with patches 1-3 its all clear what changes and why; and having the big scary conversion patch 4 invariant is good.