All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Nicolas Vigier <boklm@mars-attacks.org>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: [PATCH] git-svn: fix signed commit parsing
Date: Mon, 30 Sep 2013 12:04:04 -0700	[thread overview]
Message-ID: <20130930190404.GU9464@google.com> (raw)
In-Reply-To: <1380552374-26103-1-git-send-email-boklm@mars-attacks.org>

Nicolas Vigier wrote:

> When parsing a commit object, git-svn wrongly think that a line
> containing spaces means the end of headers and the start of the commit
> message. In case of signed commit, the gpgsig entry contains a line with
> one space, so "git svn dcommit" will include part of the signature in
> the commit message.
>
> An example of such problem :
> http://svnweb.mageia.org/treasurer?view=revision&revision=86
>
> This commit changes the regex to only match an empty line as separator
> between the headers and the commit message.
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org>

Good catch.  For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

  reply	other threads:[~2013-09-30 19:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 14:46 [PATCH] git-svn: fix signed commit parsing Nicolas Vigier
2013-09-30 19:04 ` Jonathan Nieder [this message]
2013-10-10  6:57   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930190404.GU9464@google.com \
    --to=jrnieder@gmail.com \
    --cc=boklm@mars-attacks.org \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.