From: Theodore Ts'o <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH][RESEND] tests: add another test for uninit extents past eof
Date: Mon, 30 Sep 2013 16:10:46 -0400 [thread overview]
Message-ID: <20130930201046.GC5845@thunk.org> (raw)
In-Reply-To: <20130923143518.GA2464@wallace>
On Mon, Sep 23, 2013 at 10:35:18AM -0400, Eric Whitney wrote:
> Commit d3f32c2db8 was intended to detect extents found outside their
> proper location in the extent tree, including invalid extents at the
> end of an extent block. However, it incorrectly reported legal
> uninitialized extents created by fallocate() at the end of file with
> the FALLOC_FL_KEEP_SIZE flag as false positives. xfstests
> generic/263 (among others) caught this problem, while the e2fsprogs
> test f_uninit_ext_past_eof did not. The latter test failed to
> detect the problem in part because it uses a test file whose i_size
> is 0.
>
> Add a test derived from the fsx-based test case in xfstests
> generic/263 consisting of a file with non-zero length, more than
> four extents total, and two uninitialized extents past EOF to
> reliably reproduce commit d3f32c2db8's false positive behavior.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2013-09-30 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 14:35 [PATCH][RESEND] tests: add another test for uninit extents past eof Eric Whitney
2013-09-30 20:10 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930201046.GC5845@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.