All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Stefan Beller <stefanbeller@googlemail.com>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Makefile: suppress false positive warnings of empty format string.
Date: Mon, 30 Sep 2013 14:26:36 -0700	[thread overview]
Message-ID: <20130930212636.GY9464@google.com> (raw)
In-Reply-To: <20130930201429.GA14433@sigill.intra.peff.net>

Jeff King wrote:

>                                            I think we'd be better off to
> simply mark up the few callsites. Workarounds are here:
>
>   http://article.gmane.org/gmane.comp.version-control.git/230026

Yeah, that looks okay (ugly but tolerable).  It's tempting to do
something like

	-	status_printf_ln(s, GIT_COLOR_NORMAL, "");
	+	status_nl(s, GIT_COLOR_NORMAL);

and

	-	status_printf(s, color(WT_STATUS_HEADER, s), "");
	+	status_start_line(s, color(WT_STATUS_HEADER, s));

to make the intent clearer.  Sane?

Jonathan

  reply	other threads:[~2013-09-30 21:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 23:36 What's cooking in git.git (Jul 2013, #04; Thu, 11) Junio C Hamano
2013-09-29 12:08 ` [PATCH] Makefile: suppress false positive warnings of empty format string Stefan Beller
2013-09-29 15:07   ` Felipe Contreras
2013-09-29 15:23     ` Ramsay Jones
2013-09-29 19:00   ` Jonathan Nieder
2013-09-30 20:14     ` Jeff King
2013-09-30 21:26       ` Jonathan Nieder [this message]
2013-09-30 21:34         ` Jeff King
2013-09-30 21:38       ` Stefan Beller
2013-09-30 23:23         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930212636.GY9464@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=stefanbeller@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.