All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks
Date: Mon, 30 Sep 2013 23:34:37 +0200	[thread overview]
Message-ID: <20130930213437.GG6735@lunn.ch> (raw)
In-Reply-To: <20130930213131.GB10393@obsidianresearch.com>

Hi Jason

> Our bootloader gates the power and turns off the clock, having Linux
> turn the clock back on without knowing how to control the power seems
> like a possible problem.

This patch won't do that. This patch will stop it getting turn off. It
will never turn it on. The only thing that will turn it on is the
Ethernet driver. So if the bootloader turned it off, it should stay
off.

> I don't have code, but when this was first brought up it was suggested
> to add local-mac-address to the DT nodes if it isn't present in the
> common code and don't mess with the clocks.
> 
> Psudeo code:
> 
> void marvell_dt_ethernet_fixup(void)
> {
>  for_each_compatible_node(np, "marvell,kirkwood-eth-port")
>  {
>    if (of_get_mac_address(np) != NULL)
>       continue;
>    regs = ioremap(of_regs(np->parent,0));
>    address = (readl(regs + MAC_ADDR_HIGH) << 32) | 
>               readl(regs + MAC_ADDR_LOW))
>    iounmap(regs);
>    of_add_property(np, {"local-mac-address" = address});
>  }
> }

The pseudo code looks nice, but i think in reality, the
of_add_property(np, {"local-mac-address" = address}); is not so
simple. Sebastian took a look at this.

	Andrew

  reply	other threads:[~2013-09-30 21:34 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 21:03 [PATCH 0/4] Kirkwood: minor cleanups Ezequiel Garcia
2013-09-30 21:03 ` [PATCH 1/4] ARM: kirkwood: Remove unneeded MBus initialization Ezequiel Garcia
2013-10-08 16:19   ` Jason Cooper
2013-09-30 21:03 ` [PATCH 2/4] ARM: kirkwood: Remove unneeded PCIe clock adding Ezequiel Garcia
2013-10-01 16:01   ` Ezequiel Garcia
2013-10-01 17:45     ` Jason Gunthorpe
2013-10-01 19:20     ` Arnaud Ebalard
2013-10-08 16:22   ` Jason Cooper
2013-09-30 21:03 ` [PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks Ezequiel Garcia
2013-09-30 21:31   ` Jason Gunthorpe
2013-09-30 21:34     ` Andrew Lunn [this message]
2013-09-30 21:44       ` Jason Gunthorpe
2013-10-01 14:35     ` Jason Cooper
2013-10-01  0:40   ` Jason Cooper
2013-10-01 13:42     ` Ezequiel Garcia
2013-10-01 13:49       ` Sebastian Hesselbarth
2013-10-01 14:22         ` Ezequiel Garcia
2013-10-01 14:43           ` Sebastian Hesselbarth
2013-10-01 16:45             ` Jason Gunthorpe
2013-10-01 16:49               ` Jason Cooper
2013-10-01 19:10               ` Sebastian Hesselbarth
2013-10-01 19:15                 ` Sebastian Hesselbarth
2013-10-02 12:02                 ` Jason Cooper
2013-10-02 12:05                   ` Sebastian Hesselbarth
2013-10-01 13:58       ` Jason Cooper
2013-10-01 14:17         ` Ezequiel Garcia
2013-10-01 15:01           ` Jason Cooper
2013-10-01 15:09             ` Thomas Petazzoni
2013-10-01 15:15               ` Jason Cooper
2013-10-01 15:33                 ` Thomas Petazzoni
2013-10-01 15:36                   ` Jason Cooper
2013-10-01 15:42                     ` Thomas Petazzoni
2013-10-01 15:53                       ` Jason Cooper
2013-10-01 15:59                         ` Sebastian Hesselbarth
2013-10-08 16:24   ` Jason Cooper
2013-09-30 21:03 ` [PATCH 4/4] ARM: kirkwood: Remove redundant ethernet clock enable Ezequiel Garcia
2013-09-30 21:16 ` [PATCH 0/4] Kirkwood: minor cleanups Andrew Lunn
2013-09-30 21:26   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130930213437.GG6735@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.