From: "Eric Bénard" <eric@eukrea.com>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: openembedded-devel@lists.openembedded.org,
Patch Tracking <patches@linaro.org>
Subject: Re: [meta-java][PATCH 3/3] jamvm/java: allow spaces in arguments
Date: Mon, 30 Sep 2013 21:44:16 +0200 [thread overview]
Message-ID: <20130930214416.4922028a@e6520eb> (raw)
In-Reply-To: <CAAqcGHnxp2nk2YfkBahTGkawurdj-sZ=SJVRopPL=qZO5PW9hw@mail.gmail.com>
Le Mon, 30 Sep 2013 22:22:32 +0300,
Riku Voipio <riku.voipio@linaro.org> a écrit :
> On 30 September 2013 16:58, Eric Bénard <eric@eukrea.com> wrote:
> > Hi Riku,
> >
> > Le Mon, 30 Sep 2013 16:46:11 +0300,
> > Riku Voipio <riku.voipio@linaro.org> a écrit :
> >
> >> Current IFS mangling blows up on the face:
> >>
> >> | configure:2341: javac -classpath .: Test.java
> >> | Invalid maximum heap size: -Xmx1024m-cp/srv/oe/b
> >>
> >> Simpler command line expansion works just as easy.
> >> ---
> >> recipes-core/jamvm/files/java | 7 +++----
> >> 1 file changed, 3 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/recipes-core/jamvm/files/java b/recipes-core/jamvm/files/java
> >> index 27cf094..9a396a7 100755
> >> --- a/recipes-core/jamvm/files/java
> >> +++ b/recipes-core/jamvm/files/java
> >> @@ -1,6 +1,5 @@
> >> #!/bin/sh
> >>
> >> -IFS=""
> >> -export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:STAGING_LIBDIR_NATIVE/classpath:STAGING_LIBDIR_NATIVE/jamvm"
> >> -export BOOTCLASSPATH="STAGING_DATADIR_NATIVE/jamvm/classes.zip:STAGING_DATADIR_NATIVE/classpath/glibj.zip"
> >> -exec jamvm ${1+"$@"}
> >> +export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/lib/classpath:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/lib/jamvm"
> >> +export BOOTCLASSPATH="/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share/jamvm/classes.zip:/srv/oe/build/tmp-eglibc/sysroots/x86_64-linux/usr/share/classpath/glibj.zip"
> >> +exec jamvm "$@"
>
> > so now we have your path "/srv/oe/build/tmp-eglibc/" hardcoded in the
> > recipe ;-)
>
> That is indeed not intended.. I was a bit uncertain with this patch,
> as it was not clear to me why the IFS setting was needed.
>
sorry can't help you on this point but I've added in copy Henning which
is the original author of this file and the maintainer of meta-java so
he must be the best placed to answer your question.
Eric
Eric
next prev parent reply other threads:[~2013-09-30 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 13:46 [meta-java][PATCH 1/3] jamvm compile add extra space to argument Riku Voipio
2013-09-30 13:46 ` [meta-java][PATCH 2/3] jamvm: update to latest in openjdk-7 Riku Voipio
2013-09-30 19:26 ` Henning Heinold
2013-10-01 7:30 ` Riku Voipio
2013-09-30 13:46 ` [meta-java][PATCH 3/3] jamvm/java: allow spaces in arguments Riku Voipio
2013-09-30 13:58 ` Eric Bénard
2013-09-30 19:22 ` Riku Voipio
2013-09-30 19:44 ` Eric Bénard [this message]
2013-09-30 19:30 ` Henning Heinold
2013-10-01 7:44 ` Riku Voipio
2013-10-01 8:17 ` Henning Heinold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930214416.4922028a@e6520eb \
--to=eric@eukrea.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=patches@linaro.org \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.