From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by arago-project.org (Postfix) with ESMTPS id 37F9C52099 for ; Tue, 1 Oct 2013 01:40:58 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id r911evhj020643 for ; Mon, 30 Sep 2013 20:40:57 -0500 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id r911evXg016708 for ; Mon, 30 Sep 2013 20:40:57 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.2.342.3; Mon, 30 Sep 2013 20:40:57 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id r911euvZ024000; Mon, 30 Sep 2013 20:40:57 -0500 Date: Mon, 30 Sep 2013 21:40:56 -0400 From: Denys Dmytriyenko To: "Franklin S. Cooper Jr" Message-ID: <20131001014056.GA26572@edge> References: <1380591438-30769-1-git-send-email-fcooper@ti.com> MIME-Version: 1.0 In-Reply-To: <1380591438-30769-1-git-send-email-fcooper@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-arago@arago-project.org Subject: Re: [PATCH v2] meta-toolchain-arago: Remove TARGET_SYS env variable X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 01:40:58 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Ack. On Mon, Sep 30, 2013 at 08:37:18PM -0500, Franklin S. Cooper Jr wrote: > * Within environment-setup the TARGET_SYS variable is exported but used > improperly. > * The value for --target and --host isn't the TARGET_SYS value within the > environment-setup file but rather the OE variable TARGET_SYS. > * Cross compiling autotools based applications using environment-setup > results in host and machine not recognized "configure" errors. > * Looking at toolchain-scripts.bbclass it looks like that variable has been > removed from environment-setup so mimic that change. > * Introduce new REAL_MULTIMACH_TARGET_SYS environment variable since the value > is reused in several places within environment-setup. > > Signed-off-by: Franklin S. Cooper Jr > --- > Version 2 changes: > Replace TARGET_SYS environment variable with REAL_MULTIMACH_TARGET_SYS > environment variable. > > .../recipes-core/meta/meta-toolchain-arago.bb | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb > index a8da4dc..7d01980 100644 > --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb > +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago.bb > @@ -30,17 +30,17 @@ toolchain_create_sdk_env_script () { > echo ' export SDK_PATH' >> $script > echo 'fi' >> $script > echo 'export SDK_SYS=${SDK_SYS}' >> $script > - echo 'export TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script > + echo 'export REAL_MULTIMACH_TARGET_SYS=${REAL_MULTIMACH_TARGET_SYS}' >> $script$ > echo 'export TOOLCHAIN_SYS=${TOOLCHAIN_SYS}' >> $script > echo 'export TOOLCHAIN_PREFIX=$TOOLCHAIN_SYS-' >> $script > echo 'export SDK_PATH_NATIVE=$SDK_PATH/sysroots/$SDK_SYS' >> $script > - echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$TARGET_SYS' >> $script > + echo 'export SDK_PATH_TARGET=$SDK_PATH/sysroots/$REAL_MULTIMACH_TARGET_SYS' >> $script > echo 'export PATH=$SDK_PATH_NATIVE${bindir_nativesdk}:$PATH' >> $script > echo 'export CPATH=$SDK_PATH_TARGET/usr/include:$CPATH' >> $script > echo 'export PKG_CONFIG_SYSROOT_DIR=$SDK_PATH_TARGET' >> $script > echo 'export PKG_CONFIG_PATH=$SDK_PATH_TARGET${libdir}/pkgconfig' >> $script > echo 'export PKG_CONFIG_ALLOW_SYSTEM_LIBS=1' >> $script > - echo 'export CONFIG_SITE=$SDK_PATH/site-config-$TARGET_SYS' >> $script > + echo 'export CONFIG_SITE=$SDK_PATH/site-config-$REAL_MULTIMACH_TARGET_SYS' >> $script > printf 'export CC=\x24{TOOLCHAIN_PREFIX}gcc\n' >> $script > printf 'export CXX=\x24{TOOLCHAIN_PREFIX}g++\n' >> $script > printf 'export GDB=\x24{TOOLCHAIN_PREFIX}gdb\n' >> $script > @@ -52,7 +52,7 @@ toolchain_create_sdk_env_script () { > printf 'export OBJCOPY=\x24{TOOLCHAIN_PREFIX}objcopy\n' >> $script > printf 'export OBJDUMP=\x24{TOOLCHAIN_PREFIX}objdump\n' >> $script > printf 'export STRIP=\x24{TOOLCHAIN_PREFIX}strip\n' >> $script > - echo 'export CONFIGURE_FLAGS="--target=$TARGET_SYS --host=$TARGET_SYS --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script > + echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${SDK_ARCH}-linux --with-libtool-sysroot=$SDK_PATH_TARGET"' >> $script > echo 'export CPPFLAGS="${TARGET_CC_ARCH} --sysroot=$SDK_PATH_TARGET"' >> $script > echo 'export CFLAGS="$CPPFLAGS"' >> $script > echo 'export CXXFLAGS="$CPPFLAGS"' >> $script > -- > 1.7.0.4 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago