From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennart Poettering Subject: Re: [RFC] iscsid / systemd / dracut integration effort Date: Tue, 1 Oct 2013 04:24:26 +0200 Message-ID: <20131001022426.GF14198@tango.0pointer.de> References: <1355177316-25803-1-git-send-email-cleech@redhat.com> <50C67697.7020208@gmail.com> <20121211232646.GC5307@straylight.hirudinean.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: systemd-devel-bounces+gcssd-systemd-devel=m.gmane.org@lists.freedesktop.org Errors-To: systemd-devel-bounces+gcssd-systemd-devel=m.gmane.org@lists.freedesktop.org To: The Lee-Man Cc: initramfs@vger.kernel.org, agrover@redhat.com, open-iscsi@googlegroups.com, systemd-devel@lists.freedesktop.org On Mon, 23.09.13 10:33, The Lee-Man (leeman.duncan@gmail.com) wrote: > After=network.target NetworkManager-wait-online.service tgtd.service > targetcli.service Please use network-online.target here instead of NetworkManager-wait-online.service. Please see the discussion of this unit on: http://www.freedesktop.org/software/systemd/man/systemd.special.html That said, this service makes local block devices available over the network, right, and it doesn't want to connect to anything on the network, or does it? If so, I really don't see the need for pulling in network-online.target/NetworkManager-wait-online.service here at all. > iscsi.service: > ========== > After=network.target NetworkManager-wait-online.service iscsid.service This one on the other hand actually wants network connectivity around, right, since it tries to connect to other hosts? For this one using network-online.target sounds appropriate. > ConditionPathExists=/etc/iscsi/initiatorname.iscsi > > [Service] > Type=oneshot > ExecStart=/sbin/iscsiadm -m node --loginall=automatic > ExecStop=/bin/sync Wut?? Is this really necessary? If this is really necessary (which I doubt, appears to be snake oil to me...), then why doesn't iscsiadm do this internally? Lennart -- Lennart Poettering - Red Hat, Inc.