All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] perf tool: don't print bogus data on -e instructions
Date: Tue, 1 Oct 2013 10:48:31 +0200	[thread overview]
Message-ID: <20131001084831.GG21793@gmail.com> (raw)
In-Reply-To: <1380616604-4077-1-git-send-email-artagnon@gmail.com>


* Ramkumar Ramachandra <artagnon@gmail.com> wrote:

> When only the instructions event is requested:
> 
> $ perf stat -e instructions git s
> M  builtin-stat.c
> 
>  Performance counter stats for 'git s':
> 
>        917,453,420 instructions              #    0.00  insns per cycle
> 
>        0.213002926 seconds time elapsed
> 
> The 0.00 insns per cycle comment in the output is totally bogus and
> misleading. It happens because update_shadow_stats() doesn't touch
> runtime_cycles_stats when only the instructions event is requested. So,
> omit printing the bogus data altogether.
> 
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  reply	other threads:[~2013-10-01  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  8:36 [PATCH] perf tool: don't print bogus data on -e instructions Ramkumar Ramachandra
2013-10-01  8:48 ` Ingo Molnar [this message]
2013-10-15  5:29 ` [tip:perf/core] perf stat: Don' t " tip-bot for Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131001084831.GG21793@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=artagnon@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.