From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] logrotate: nees mmu
Date: Tue, 1 Oct 2013 09:32:49 +0200 [thread overview]
Message-ID: <20131001093249.6a135a15@skate> (raw)
In-Reply-To: <1380594702.9353.1.camel@phoenix>
Dear Axel Lin,
On Tue, 01 Oct 2013 10:31:42 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Fix below build error:
>
> logrotate.o: In function `switch_user_permanently':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork'
> logrotate.o: In function `removeLogFile':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork'
> logrotate.o: In function `mailLog':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork'
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork'
> logrotate.o: In function `compressLogFile':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
> collect2: ld returned 1 exit status
> make[1]: *** [logrotate] Error 1
It's a minor comment, but I believe the log of the error could go
within the commit log itself (i.e, before the --- separator). It really
is part of the explanation of why the change is needed.
Note that there is no need to resend this patch just for this reason,
it was merely a suggestion for future patches.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-01 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 2:31 [Buildroot] [PATCH 1/2] logrotate: nees mmu Axel Lin
2013-10-01 2:32 ` [Buildroot] [PATCH 2/2] logrotate: bump to version 3.8.6 Axel Lin
2013-10-01 19:33 ` Peter Korsgaard
2013-10-01 7:32 ` Thomas Petazzoni [this message]
2013-10-01 8:08 ` [Buildroot] [PATCH 1/2] logrotate: nees mmu Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001093249.6a135a15@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.